Skip to content

refactor: preserve multi-line formatting in generated doc comments #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 3, 2025
+1,919 −601
Merged

refactor: preserve multi-line formatting in generated doc comments #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59d2da8
chore: bump ACP schema to v0.6.2
ThomasK33 Oct 24, 2025
7cb687c
chore: bump ACP schema to v0.6.3
ThomasK33 Nov 2, 2025
c86d96e
refactor: preserve multi-line formatting in generated doc comments
ThomasK33 Nov 2, 2025
29498a9
feat: support JSON Schema discriminators for ergonomic union names
ThomasK33 Nov 3, 2025
a5de80e
fix: use type alias for extension types to preserve JSON methods
ThomasK33 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Learn more about the protocol itself at <https://agentclientprotocol.com>.
<!-- `$ printf 'go get github.com/coder/acp-go-sdk@v%s\n' "$(cat schema/version)"` as bash -->

```bash
go get github.com/coder/acp-go-sdk@v0.4.9
go get github.com/coder/acp-go-sdk@v0.6.3
```

## Get Started
Expand Down
2 changes: 1 addition & 1 deletion acp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ func TestConnectionHandlesMessageOrdering(t *testing.T) {
}
if _, err := as.RequestPermission(context.Background(), RequestPermissionRequest{
SessionId: "test-session",
ToolCall: ToolCallUpdate{
ToolCall: RequestPermissionToolCall{
Title: Ptr("Execute command"),
Kind: ptr(ToolKindExecute),
Status: ptr(ToolCallStatusPending),
Expand Down
Loading