Merged
Conversation
ethanndickson
approved these changes
Mar 26, 2026
Member
ethanndickson
left a comment
ethanndickson
left a comment
There was a problem hiding this comment.
One thing to fix before merging!
|
|
||
| private var fullItemName: String { | ||
| item.primaryHost(hostnameSuffix: state.hostnameSuffix) | ||
| } |
Member
There was a problem hiding this comment.
Can we replace all references to item.primaryHost(hostnameSuffix: state.hostnameSuffix) elsewhere in this struct with fullItemName to avoid repeating ourselves?
Also, why full? itemName is already full. Maybe this should be plainItemName since itemName is the formatted/stylized one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request makes it so that on hover we show the full workspace name. This allows the user to distinguish between similarly named workspaces when they're side by side.