Open
Conversation
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
mux-bot
bot
force-pushed
the
auto-cleanup
branch
14 times, most recently
from
104b37a to
3a72ecd
Compare
The import of buildArchiveConfirmDescription and buildArchiveConfirmWarning was placed after the WorkspaceMenuBarProps interface definition instead of with the other imports. This was an artifact of the extraction in ae2e555. Move it to the import section where it belongs, grouped with other @/browser/utils/ imports.
…pshot service Deduplicate two identical 14-line blocks in captureSnapshotForArchive that fetch latest untracked paths and return confirmation errors. Both code paths (new-untracked-after-acknowledgement and first-time-untracked) now call the same private helper method. Behavior-preserving: no logic change, same call sequence and return values.
Merged two separate `import type` statements from the same `@/common/types/workspace` module into a single import line, consistent with how other files in the codebase handle multiple type imports from the same module.
Both getHeartbeatSettings and setHeartbeatSettings had nearly identical object literals duplicated across two ternary branches, differing only by the optional message field. Use conditional spread to build each object once, removing the duplicated comment in setHeartbeatSettings.
After the HEARTBEAT_MAX_MESSAGE_LENGTH removal (5f002d8), normalizeHeartbeatMessageInput became functionally identical to sanitizeHeartbeatMessage for its string | undefined input type. The only distinguishing logic was the max-length assert which no longer exists. Consolidate both callsites to use the single sanitizeHeartbeatMessage function, which safely handles both user input and persisted config values.
The AddSectionButton component was removed from ProjectSidebar's imports in #3099 but the component file and its test mock were left behind. Remove both since nothing references them anymore.
Replace direct localStorage.setItem(LEFT_SIDEBAR_COLLAPSED_KEY, ...) with the collapseLeftSidebar() helper that already exists in uiState.ts, and remove the now-unused LEFT_SIDEBAR_COLLAPSED_KEY import.
…ppers After the compaction handler refactor (710bda5), the production callers were migrated to use the new *State methods directly. The old *Diffs wrappers had zero remaining callers: - discardPendingDiffs: no callers in production code or tests - ackPendingDiffsConsumed: one caller in agentSession.ts, now updated to call ackPendingStateConsumed directly peekPendingDiffs is retained as it's still used by tests as a convenience accessor.
mux-bot
bot
force-pushed
the
auto-cleanup
branch
from
3a72ecd to
9ff0835
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-cleanup checkpoint: 710bda5