Skip to content

🤖 fix: remove review line tooltip#3091

Open
ammar-agent wants to merge 1 commit intomainfrom
fix/remove-review-line-tooltip
Open

🤖 fix: remove review line tooltip#3091
ammar-agent wants to merge 1 commit intomainfrom
fix/remove-review-line-tooltip

Conversation

@ammar-agent
Copy link
Copy Markdown
Collaborator

@ammar-agent ammar-agent commented Mar 29, 2026

Summary

Remove the floating review helper tooltip from the shared review gutter renderer so hovering the line action no longer covers nearby code in either review pane.

Background

In review mode, the hover tooltip on the line comment action was distracting and got in the way of reading the diff. Both the review panel and immersive review view already expose that action inline through the shared gutter renderer, so the extra floating hint was redundant.

Implementation

  • delete the shared portal-based review tooltip state and rendering from SelectableDiffRenderer
  • keep the inline review button and existing click / shift-click / drag selection behavior intact
  • clarify in the shared renderer comments that the change applies to both review panes
  • update the drag-selection test to assert that hovering no longer renders the tooltip text

Validation

  • make static-check
  • bun test src/browser/features/Shared/SelectableDiffRenderer.dragSelect.test.tsx

Risks

Low. This only changes the review gutter hover affordance; inline review actions and range selection behavior are unchanged.


Generated with mux • Model: openai:gpt-5.4 • Thinking: xhigh • Cost: $1.93

@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Stop rendering the floating review comment helper from the shared review diff renderer so hovering the gutter action no longer obscures nearby code. The shared renderer also powers both review panes, so the follow-up comment now calls out that scope directly while preserving the inline review action and range selection behavior.

---

_Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$1.93`_

<!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=1.93 -->
@ammar-agent ammar-agent force-pushed the fix/remove-review-line-tooltip branch from 17d2f71 to 85f35be Compare April 2, 2026 15:28
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant