Skip to content

add oracle oci-vm template#525

Open
aniskhalfallah wants to merge 8 commits intocoder:mainfrom
aniskhalfallah:oci-vm
Open

add oracle oci-vm template#525
aniskhalfallah wants to merge 8 commits intocoder:mainfrom
aniskhalfallah:oci-vm

Conversation

@aniskhalfallah
Copy link
Contributor

Description

Add oci-vm template to coder

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Template Information

Path: registry/anis/templates/oci-vm

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun fmt)
  • Changes tested locally
oracle_oci_coder_template_demo.mp4

Related Issues

Closes #201
/claim #201

Signed-off-by: Anis KHALFALLAH <khalfallah.anis@hotmail.com>
Signed-off-by: Anis KHALFALLAH <khalfallah.anis@hotmail.com>
@DevelopmentCats
Copy link
Contributor

@aniskhalfallah Thank you very much for the contribution!

I love the thorough video showing absolutely everything. I will go ahead and test this and review it and this should be an easy merge :)

@DevelopmentCats
Copy link
Contributor

Also @aniskhalfallah

I would run bun fmt on this and it should satisfy the CI

aniskhalfallah and others added 2 commits November 10, 2025 22:02
Signed-off-by: Anis KHALFALLAH <khalfallah.anis@hotmail.com>
@aniskhalfallah
Copy link
Contributor Author

@DevelopmentCats Thanks for your words!
Let me know how the testing goes, happy to address any feedback.
Thanks for the heads up on bun fmt, just ran it and pushed the changes.

@DevelopmentCats DevelopmentCats mentioned this pull request Dec 16, 2025
9 tasks
@DevelopmentCats
Copy link
Contributor

@aniskhalfallah

Can you resolve the merge conflicts, and I will follow up with the guy that I have testing this.

@aniskhalfallah
Copy link
Contributor Author

@DevelopmentCats Done! The merge conflict has been resolved

@DevelopmentCats
Copy link
Contributor

I'm going to go ahead and just set up an account for this so I can test it and we can get this merged. Sorry for the delay on this OCI is tricky haha. @aniskhalfallah

Comment on lines +36 to +40
variable "private_key" {
description = "Private Key File"
type = string
default = ""
}
Copy link
Contributor

@DevelopmentCats DevelopmentCats Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experience Private Keys are almost always multi-line keys.

It might be better to do something like this instead as its more realistic for what must be done to run this template in my experience.

Suggested change
variable "private_key" {
description = "Private Key File"
type = string
default = ""
}
variable "private_key" {
description = "Private Key File"
type = string
default = <<EOT
-----BEGIN PRIVATE KEY-----
YourKeyHere
-----END PRIVATE KEY-----
EOT
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you technically do explain this in the README so its probably really not that big of a deal.

Copy link
Contributor

@DevelopmentCats DevelopmentCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to go over the instances and regions in the README since these need to be configured based on the location and available compute available to the user of this template @aniskhalfallah

Also you may want to go over what actually persists when the workspace stops vs when its deleted. I think the behavior is probably ideal, but if its not mentioned people will definitely question this when resources are still existing for stopped workspaces.

Lastly you may want to remove compartment_id from the template entirely, as I get a deprecation notice from OCI when using it explicitly stating "Do Not Use This"

@DevelopmentCats
Copy link
Contributor

I am fairly certain this template will work, but for whatever reason I can not get it to work with my trial account.

I think something with trial accounts prevents me from utilizing the API to create compute resources or something, but it does not seem to be related to the terraform configuration.

Honestly I think we can probably call this good since ultimately IMHO this looks accurate for a starter template for OCI, and anyone using OCI should be able to configure this on their own in regards to instance types and regions.

I would address my above comments though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Oracle Cloud Infrastructure (OCI) template example

3 participants