Conversation
Signed-off-by: Anis KHALFALLAH <khalfallah.anis@hotmail.com>
Signed-off-by: Anis KHALFALLAH <khalfallah.anis@hotmail.com>
|
@aniskhalfallah Thank you very much for the contribution! I love the thorough video showing absolutely everything. I will go ahead and test this and review it and this should be an easy merge :) |
|
Also @aniskhalfallah I would run |
Signed-off-by: Anis KHALFALLAH <khalfallah.anis@hotmail.com>
|
@DevelopmentCats Thanks for your words! |
|
Can you resolve the merge conflicts, and I will follow up with the guy that I have testing this. |
|
@DevelopmentCats Done! The merge conflict has been resolved |
|
I'm going to go ahead and just set up an account for this so I can test it and we can get this merged. Sorry for the delay on this OCI is tricky haha. @aniskhalfallah |
| variable "private_key" { | ||
| description = "Private Key File" | ||
| type = string | ||
| default = "" | ||
| } |
There was a problem hiding this comment.
In my experience Private Keys are almost always multi-line keys.
It might be better to do something like this instead as its more realistic for what must be done to run this template in my experience.
| variable "private_key" { | |
| description = "Private Key File" | |
| type = string | |
| default = "" | |
| } | |
| variable "private_key" { | |
| description = "Private Key File" | |
| type = string | |
| default = <<EOT | |
| -----BEGIN PRIVATE KEY----- | |
| YourKeyHere | |
| -----END PRIVATE KEY----- | |
| EOT | |
| } |
There was a problem hiding this comment.
I guess you technically do explain this in the README so its probably really not that big of a deal.
There was a problem hiding this comment.
You may want to go over the instances and regions in the README since these need to be configured based on the location and available compute available to the user of this template @aniskhalfallah
Also you may want to go over what actually persists when the workspace stops vs when its deleted. I think the behavior is probably ideal, but if its not mentioned people will definitely question this when resources are still existing for stopped workspaces.
Lastly you may want to remove compartment_id from the template entirely, as I get a deprecation notice from OCI when using it explicitly stating "Do Not Use This"
|
I am fairly certain this template will work, but for whatever reason I can not get it to work with my trial account. I think something with trial accounts prevents me from utilizing the API to create compute resources or something, but it does not seem to be related to the terraform configuration. Honestly I think we can probably call this good since ultimately IMHO this looks accurate for a starter template for OCI, and anyone using OCI should be able to configure this on their own in regards to instance types and regions. I would address my above comments though. |
Description
Add oci-vm template to coder
Type of Change
Template Information
Path:
registry/anis/templates/oci-vmTesting & Validation
bun test)bun fmt)oracle_oci_coder_template_demo.mp4
Related Issues
Closes #201
/claim #201