feat(nodejs): add pre and post install scripts with coder exp sync support#802
Open
blinkagent[bot] wants to merge 8 commits intomainfrom
Open
feat(nodejs): add pre and post install scripts with coder exp sync support#802blinkagent[bot] wants to merge 8 commits intomainfrom
blinkagent[bot] wants to merge 8 commits intomainfrom
Conversation
…pport Add pre_install_script and post_install_script variables to the nodejs module following the pattern used by other registry modules (agent-helper, claude-code, aider, etc.). Scripts use coder exp sync for reliable execution ordering, enabling dependency coordination between modules. Changes: - Add pre_install_script and post_install_script optional variables - Wrap install script with coder exp sync want/start/complete - Add conditional pre/post install coder_script resources - Export sync script names as outputs for cross-module coordination - Add nodejs.tftest.hcl with 5 test cases - Update README with pre/post install documentation and examples - Bump version references to 1.0.14
Remove all the coder exp sync machinery, separate script resources, locals, and outputs. Simply pass the scripts as template variables into run.sh and eval them before/after the nvm install.
… install scripts - Base64 encode pre/post install scripts to safely handle special characters - Use separate coder_script resources for pre_install, install, and post_install - Add coder exp sync want/start/complete for execution ordering - Base64 encode the main install script (run.sh) via templatefile + base64encode - Revert run.sh to original (no pre/post install handling) - Add sync name outputs for cross-module dependency coordination - Update README with cross-module coordination documentation - Add output assertions to tests
Contributor
|
I have tested this and it works well Using these The pre and post install scripts are just for flexibility if someone wants to just use the node module, and post install commands to install whatever they would need. |
DevelopmentCats
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
pre_install_scriptandpost_install_scriptvariables to thethezoker/nodejsmodule, following the pattern established by other registry modules (agent-helper, claude-code, aider, goose, amazon-q, etc.). Scripts usecoder exp syncfor reliable execution ordering, enabling dependency coordination between modules.Changes:
pre_install_scriptandpost_install_scriptoptional variables (defaultnull)coder exp syncwant/start/complete flowcoder_scriptresources for pre/post installnodejs.tftest.hclwith 5 test casesType of Change
Module Information
Path:
registry/thezoker/modules/nodejsNew version: N/A (enhancement to existing module)
Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)terraform validatesuccessterraform test— 5 passed, 0 failednull)Related Issues
None