Conversation
* fix: add files field to core and server packages to exclude tests and source from npm * fix: remove explicit pnpm version from workflows to avoid conflict with packageManager * fix: build core before typecheck to resolve workspace dependency in CI
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
First release PR for the ChatCops packages, focusing on publishable package contents and ensuring CI/release workflows build prerequisites in the correct order for monorepo dependencies.
Changes:
- Limit published contents for
@chatcops/coreand@chatcops/servertodist/via thefilesfield. - Update CI and release workflows to rely on the repo’s pinned
packageManagerpnpm version (remove explicitversion: 9). - Add a “Build core” step before typechecking to satisfy
@chatcops/server’s dependency on@chatcops/corebuild artifacts.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/core/package.json |
Adds files: ["dist"] to ensure only built artifacts are published. |
packages/server/package.json |
Adds files: ["dist"] to ensure only built artifacts are published. |
.github/workflows/ci.yml |
Removes explicit pnpm version pin and builds core before typecheck. |
.github/workflows/release.yml |
Removes explicit pnpm version pin and builds core before typecheck/publish. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/ci.yml
Outdated
| - name: Build core (required by server) | ||
| run: pnpm --filter @chatcops/core build | ||
|
|
There was a problem hiding this comment.
@chatcops/core is built explicitly here and then built again during the later pnpm -r build step, which makes CI/release slower and duplicates work. Consider either moving the full build (pnpm -r build) before typecheck/tests (and dropping this step), or adjusting the later build to exclude core so it only runs once.
.github/workflows/release.yml
Outdated
| - name: Build core (required by server) | ||
| run: pnpm --filter @chatcops/core build | ||
|
|
There was a problem hiding this comment.
@chatcops/core is built explicitly here and then built again during the later pnpm -r build step, which duplicates work in the release workflow. Consider building everything once before typecheck/tests, or excluding core from the later recursive build so this package isn’t rebuilt.
Summary
First release of ChatCops packages.
Included fixes
filesfield to exclude tests/source from npmInfrastructure
Test plan
npm pack --dry-runverified for all 3 packages