perf: improve React Native styling performance #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance optimizations implemented: - Add style caching with Map for variant combinations - Move StyleSheet.create() outside render functions (pre-compute at definition time) - Add React.memo() to styled components to prevent unnecessary re-renders - Implement dynamic style caching for function-based styles - Replace object spread operations with Object.assign for better performance Testing improvements: - Add custom React Native mocks for reliable testing without vitest-react-native plugin - Fix vitest configuration for proper module resolution - All 29 tests pass with 97.63% code coverage https://claude.ai/code/session_01BZAtkgZYULp6FnFbSsPJBm
Additional performance optimizations: - Replace generateCacheKey array methods with manual string building - Replace resolveTokens reduce() with for-in loop (resolveTokensFast) - Pre-compute compound variant matchers at definition time - Use direct Map access instead of wrapper functions - Eliminate object allocations in render path with type-safe casting - Optimize style merging to avoid array spread operators - Pre-sort variant keys once at definition time for fast cache key gen - Reuse rest object in styled components instead of Object.assign - Pre-allocate arrays with exact size instead of spread Key changes: - generateCacheKeyFast: O(n) string concatenation vs O(n log n) sort + map + join - resolveTokensFast: for-in loop vs Object.entries().reduce() - Direct Map.get/set vs wrapper function calls - Avoid creating new arrays/objects in hot render paths https://claude.ai/code/session_01BZAtkgZYULp6FnFbSsPJBm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance optimizations implemented:
Testing improvements:
https://claude.ai/code/session_01BZAtkgZYULp6FnFbSsPJBm