This repository was archived by the owner on Apr 9, 2020. It is now read-only.
Sending error in json to unmatched routes#43
Open
himanshuc3 wants to merge 1 commit intocoding-blocks:masterfrom
himanshuc3:error
Open
Sending error in json to unmatched routes#43himanshuc3 wants to merge 1 commit intocoding-blocks:masterfrom himanshuc3:error
himanshuc3 wants to merge 1 commit intocoding-blocks:masterfrom
himanshuc3:error
Conversation
championswimmer
suggested changes
May 28, 2018
|
|
||
| app.get('*', (req, res) => { | ||
| res.status(404).json({ | ||
| "error": "404", |
Contributor
There was a problem hiding this comment.
a json cannot have two keys of the same name. like javascript 101 my friend.
please at least run your code before you make PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was not enough information on issue, So I thought unmatched route error message have to be sent in json.
Issue #13