fix: relax tokenizers version constraint#514
Conversation
|
Hello @nightcityblade, thanks for the PR. Can you please take a look at failing CI ? 🙏 |
|
I checked the failed run in detail. The breakage is in the server inference tests, where / were never created before the assertions ran. That doesn't appear to come from the tokenizers pin change itself, so this looks more like a test/server-startup failure than a dependency-resolution failure. I can't rerun the workflow from my side because GitHub reports I don't have the required repository permissions, but I'm happy to dig further if the next run shows the same pattern. |
There was a problem hiding this comment.
Pull request overview
This PR relaxes the tokenizers dependency constraint to allow compatibility with both the existing Transformers 4.46.x stack and newer Transformers releases (through 4.57.x), addressing dependency resolution conflicts reported in #508.
Changes:
- Update
setup.pyto allowtokenizers>=0.20.3,<0.23instead of hard-pinningtokenizers==0.20.3. - Update
requirements/server.txtto match the sametokenizersconstraint for server installs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
setup.py |
Relaxes package install dependency to a bounded tokenizers range to support multiple Transformers versions. |
requirements/server.txt |
Keeps server requirements aligned with the package’s tokenizers constraint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Thanks, I did run CI a couple of times on the PR and it always fails, so probably not due to flaky tests. If you could dig deeper that would be very much appreciated. 🙏 |
Summary
Relax the tokenizers dependency from a single pinned version to a bounded range that supports both the current Transformers 4.46 stack and newer Transformers releases through 4.57.
Fixes #508
List of files changed and why
setup.py- allowtokenizers>=0.20.3,<0.23instead of only0.20.3.requirements/server.txt- keep server requirements aligned with package metadata.How Has This Been Tested?
python3 -m py_compile setup.py/tmp/whisperlive-venv/bin/python -m pip install --dry-run 'transformers==4.57.1' 'tokenizers>=0.20.3,<0.23'\n-/tmp/whisperlive-venv/bin/python -m pip install --dry-run 'transformers==4.46.3' 'tokenizers>=0.20.3,<0.23'\n