Skip to content

Prepare 0.3.5 release#125

Merged
sjoerdsimons merged 1 commit into
mainfrom
release
Jun 23, 2026
Merged

Prepare 0.3.5 release#125
sjoerdsimons merged 1 commit into
mainfrom
release

Conversation

@sjoerdsimons

Copy link
Copy Markdown
Contributor

Bump Cargo.toml, chart version and appVersion all to 0.3.5. Comment image.tag in values so it will default to the appVersion (which should match)

The chart version isn't necesarilly expected to be in sync with the App version, however as it was seemingly never even bumped (and should be bumped on app changes), just sync them all up and we can see how it goes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the 0.3.5 release by aligning the Rust crate version and Helm chart metadata, and adjusting Helm values so the image tag can default from the chart’s appVersion.

Changes:

  • Bump Cargo.toml package version to 0.3.5
  • Bump Helm chart version and appVersion to 0.3.5
  • Comment out image.tag in Helm values.yaml so the deployment uses the default tag derived from appVersion

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
chart/values.yaml Comments out image.tag so the chart defaults to .Chart.AppVersion for the image tag
chart/Chart.yaml Updates Helm chart version and appVersion to 0.3.5
Cargo.toml Updates crate version to 0.3.5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread chart/Chart.yaml Outdated
Comment thread chart/values.yaml Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread chart/values.yaml
Comment thread chart/Chart.yaml
Bump Cargo.toml, chart version and appVersion all to 0.3.5. Comment
image.tag in values so it will default to the appVersion (which should
match)

The chart version isn't necesarilly expected to be in sync with the App
version, however as it was seemingly never even bumped (and should be bumped
on app changes), just sync them all up and we can see how it goes

@emanueleaina emanueleaina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahah Cargo.lock is already living in the future, 9b61a52 already bumped the lava-gitlab-runner version there to 0.3.5 (I have no idea why the version of this crate also ends up in Cargo.lock and if it is the right thing to do or not).

That said, looks good to me, thank you!

@sjoerdsimons

Copy link
Copy Markdown
Contributor Author

Ahah Cargo.lock is already living in the future, 9b61a52 already bumped the lava-gitlab-runner version there to 0.3.5 (I have no idea why the version of this crate also ends up in Cargo.lock and if it is the right thing to do or not).

cargo by default will pick the last version that's compatible semver and msrv wise, so someone updated the lock as part of some other work causing that to happen. The change in the Cargo.toml is to set the minimal version as well to be really sure we get that fix ;)

@sjoerdsimons sjoerdsimons added this pull request to the merge queue Jun 23, 2026
Merged via the queue into main with commit 6f83d10 Jun 23, 2026
16 checks passed
@sjoerdsimons sjoerdsimons deleted the release branch June 23, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants