Prepare 0.3.5 release#125
Conversation
There was a problem hiding this comment.
Pull request overview
Prepares the 0.3.5 release by aligning the Rust crate version and Helm chart metadata, and adjusting Helm values so the image tag can default from the chart’s appVersion.
Changes:
- Bump
Cargo.tomlpackage version to0.3.5 - Bump Helm chart
versionandappVersionto0.3.5 - Comment out
image.tagin Helmvalues.yamlso the deployment uses the default tag derived fromappVersion
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
chart/values.yaml |
Comments out image.tag so the chart defaults to .Chart.AppVersion for the image tag |
chart/Chart.yaml |
Updates Helm chart version and appVersion to 0.3.5 |
Cargo.toml |
Updates crate version to 0.3.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bump Cargo.toml, chart version and appVersion all to 0.3.5. Comment image.tag in values so it will default to the appVersion (which should match) The chart version isn't necesarilly expected to be in sync with the App version, however as it was seemingly never even bumped (and should be bumped on app changes), just sync them all up and we can see how it goes
emanueleaina
left a comment
There was a problem hiding this comment.
Ahah Cargo.lock is already living in the future, 9b61a52 already bumped the lava-gitlab-runner version there to 0.3.5 (I have no idea why the version of this crate also ends up in Cargo.lock and if it is the right thing to do or not).
That said, looks good to me, thank you!
cargo by default will pick the last version that's compatible semver and msrv wise, so someone updated the lock as part of some other work causing that to happen. The change in the Cargo.toml is to set the minimal version as well to be really sure we get that fix ;) |
Bump Cargo.toml, chart version and appVersion all to 0.3.5. Comment image.tag in values so it will default to the appVersion (which should match)
The chart version isn't necesarilly expected to be in sync with the App version, however as it was seemingly never even bumped (and should be bumped on app changes), just sync them all up and we can see how it goes