fix: persist company filter across offer tabs - #899
Open
0xgny wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description ✏️
Closes #898
Persists the company filter when switching between the Internships and Full-Time
tabs, and adds a clearer empty state when the selected company has no offers of
that type.
logic is inside the component, so the desktop and mobile navs both get it.
is Full-Time-only, and the location options are built per offer type, so
forwarding those could filter a tab by a value missing from its own dropdown.
page is dropped so you don't land on page 4 of a one-page list.
internship offers at {company} yet." It only shows when company is the sole
active filter, since otherwise the empty result may be caused by the others.
changes were needed.
Type of Change 🐞
Checklist ✅