[OPIK-3531] [BE] Add query logs for TraceDAO #4495
Conversation
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
apps/opik-backend/src/main/java/com/comet/opik/infrastructure/DatabaseUtils.java
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/infrastructure/DatabaseUtils.java
Show resolved
Hide resolved
Backend Tests Results6 280 tests 6 270 ✅ 57m 44s ⏱️ Results for commit 5158b06. ♻️ This comment has been updated with latest results. |
SDK E2E Tests Results0 tests 0 ✅ 0s ⏱️ Results for commit 5158b06. ♻️ This comment has been updated with latest results. |
BorisTkachenko
force-pushed
the
boryst/OPIK-3531-be-add-query-logging-for-trace-related-queries
branch
from
a5b12bc to
cb4145a
Compare
| private ST newBulkUpdateTemplate(TraceUpdate traceUpdate, String sql, boolean mergeTags, String workspaceId) { | ||
| var template = getSTWithLogComment(sql, "bulk_update_traces", workspaceId, ""); | ||
|
|
||
| if (StringUtils.isNotBlank(traceUpdate.name())) { |
There was a problem hiding this comment.
bulk_update_traces is rendered through getSTWithLogComment with an empty details argument, so the new log_comment string is always just bulk_update_traces:<workspace>:. Because bulk updates are one of the few batch queries that actually vary in size, this prevents the structured log comment from capturing the ids/count that give it meaning, which violates the logging guidance in AGENTS.md (Repository-Wide Code Review Guidelines) that new instrumentation should include useful context.
| private ST newBulkUpdateTemplate(TraceUpdate traceUpdate, String sql, boolean mergeTags, String workspaceId) { | |
| var template = getSTWithLogComment(sql, "bulk_update_traces", workspaceId, ""); | |
| if (StringUtils.isNotBlank(traceUpdate.name())) { | |
| private ST newBulkUpdateTemplate(TraceUpdate traceUpdate, String sql, boolean mergeTags, String workspaceId) { | |
| var template = getSTWithLogComment(sql, "bulk_update_traces", workspaceId, "bulk_operation"); | |
| if (StringUtils.isNotBlank(traceUpdate.name())) { |
Finding type: AI Coding Guidelines
Details
Add query logs for TraceDAO
Change checklist
Issues
Testing
NA
Documentation
NA