-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[OPIK-3563] [FE] Improve mobile responsiveness for Log a trace SideDialog #4564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[OPIK-3563] [FE] Improve mobile responsiveness for Log a trace SideDialog #4564
Conversation
…OPIK-3563-improve-responsiveness-log-a-trace-sidedialog
|
✅ Test environment is now available! To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml) Access Information
The deployment has completed successfully and the version has been verified. |
...ntend/src/components/pages-shared/onboarding/IntegrationListLayout/IntegrationListLayout.tsx
Outdated
Show resolved
Hide resolved
...rontend/src/components/pages-shared/onboarding/FrameworkIntegrations/IntegrationTemplate.tsx
Outdated
Show resolved
Hide resolved
…eight, prevent text wrapping
...rontend/src/components/pages-shared/onboarding/FrameworkIntegrations/IntegrationTemplate.tsx
Outdated
Show resolved
Hide resolved
03c7666 to
4439840
Compare
...rontend/src/components/pages-shared/onboarding/FrameworkIntegrations/IntegrationTemplate.tsx
Outdated
Show resolved
Hide resolved
…-a-trace-sidedialog
|
✅ Test environment is now available! To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml) Access Information
The deployment has completed successfully and the version has been verified. |
Details
This PR improves the mobile responsiveness of the "Log a trace" SideDialog component with a Select dropdown pattern based on the Figma design to provide optimal user experience on phone devices, particularly in portrait orientation.
Figma Design Reference
Design: Onboarding - Select framework
Implementation Summary
Mobile-First Select Dropdown Design Using
useIsPhoneHook:useIsPhonehook to conditionally render layouts based on device type and orientationComponent Changes:
FrameworkIntegrations Component (
FrameworkIntegrations.tsx)isPhonePortraitstateIntegrationListLayout Component (
IntegrationListLayout.tsx)GetStartedSection Component (
GetStartedSection.tsx)w-full px-4)m-auto w-[468px])UX Benefits
Select Dropdown Pattern Advantages:
User Flow:
Technical Approach
useIsPhonehook for accurate device identificationDesign System Integration
@radix-ui/react-selectvia existingcomponents/ui/select.tsxChange checklist
Issues
Testing
Manual Testing Scenarios:
Portrait Phone Mode (≤767px, touch device, portrait orientation):
Desktop/Landscape Mode:
Device Compatibility:
Quality Checks Passed:
Documentation
useIsPhonehook follows established patterns inapps/opik-frontend/src/hooks/useIsPhone.tscomponents/ui/select.tsx)Related Work:
Design Rationale: