Skip to content

Return constant from signing fn #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thomaseizinger wants to merge 1 commit into
base: remove-private-public-key-indirection
Choose a base branch
from
Draft

Return constant from signing fn #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/clsag.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ mod tests {
#[allow(non_snake_case)]
let I = signing_key * H_p_pk;

let signature = sign(
let (signature, _) = sign(
msg_to_sign,
signing_key,
signing_key_index,
Expand Down
19 changes: 12 additions & 7 deletions src/clsag/sign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ pub fn sign(
L: EdwardsPoint,
R: EdwardsPoint,
I: EdwardsPoint,
) -> Clsag {
) -> (Clsag, Scalar) {
let D = z * H_p_pk;
let D_inv_8 = D * INV_EIGHT;
let adjusted_commitment_ring =
Expand Down Expand Up @@ -97,11 +97,16 @@ pub fn sign(
h_prev = h
}

responses[signing_key_index] = alpha - h_prev * ((mu_P * signing_key) + (mu_C * z));
let stupid_constant = h_prev * mu_C * z;

Clsag {
s: responses.to_vec(),
c1: h_0,
D: D_inv_8,
}
responses[signing_key_index] = alpha - h_prev * mu_P * signing_key - stupid_constant;

(
Clsag {
s: responses.to_vec(),
c1: h_0,
D: D_inv_8,
},
stupid_constant,
)
}