Skip to content

Honda - electric brake booster refactor #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Honda - electric brake booster refactor #2919

wants to merge 8 commits into from

Conversation

@mvl-boston
Copy link
Contributor

@mvl-boston mvl-boston commented Nov 29, 2025 •
edited
Loading

Refactor of electric brake booster

  • Renaming from alt_brake to electric_brake_booster, message correlates with presence of electric brake booster in fingerprint
  • Moving from manual flagging to autodetect, to make it easier to merge new cars.

Todo:

  • Validate in test routes that there is no model with a 0x1BE messages that was not previously mapped to ALT_BRAKE - confirmed see here
  • Check Honda Civic Bosch routes in huggingface - only car with electric brake booster in fingerprints.py, and not having ALT_BRAKE in Honda flags code

@github-actions github-actions bot added car related to opendbc/car/ honda car safety vehicle-specific safety code labels Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

car safety vehicle-specific safety code car related to opendbc/car/ honda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mvl-boston