Skip to content

Fix empty state of subscriptions listing page - #515

Merged
pfferrari merged 3 commits into
mainfrom
feat/705-subscriptions-fix-empty-state
Sep 2, 2026
Merged

Fix empty state of subscriptions listing page#515
pfferrari merged 3 commits into
mainfrom
feat/705-subscriptions-fix-empty-state

Conversation

@pfferrari

Copy link
Copy Markdown
Contributor

Closes commercelayer/issues-app/issues/705

What I did

Fixed the copy of the empty state of the listing page of the subscriptions app that was wrongly advicing to create a new subscription by clicking a button while the create feature via dashboard is actually missing.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@pfferrari pfferrari self-assigned this Sep 1, 2026
@netlify

netlify Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploy Preview for commercelayer-dashboard-apps ready!

Name Link
🔨 Latest commit 2809710
🔍 Latest deploy log https://app.netlify.com/projects/commercelayer-dashboard-apps/deploys/6a97f70fb63b9100076f18ae
😎 Deploy Preview https://deploy-preview-515--commercelayer-dashboard-apps.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pfferrari pfferrari added the bug Something isn't working label Sep 1, 2026
@pfferrari pfferrari changed the title Fix empty state of promotions list Fix empty state of promotions listing page Sep 1, 2026
@malessani malessani changed the title Fix empty state of promotions listing page Fix empty state of subscriptions listing page Sep 2, 2026

@malessani malessani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the copy to: No subscriptions match the current filters.

@pfferrari
pfferrari force-pushed the feat/705-subscriptions-fix-empty-state branch from 3c9ef1e to 2809710 Compare September 2, 2026 10:14
@pfferrari
pfferrari requested a review from malessani September 2, 2026 10:15
@pfferrari
pfferrari merged commit 599edc5 into main Sep 2, 2026
6 checks passed
@pfferrari
pfferrari deleted the feat/705-subscriptions-fix-empty-state branch September 2, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants