This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Derived additional labels for prometheus #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3ph
reviewed
May 2, 2022
measurer/base_measurer.go
Outdated
| TypeName: strings.Split(p.TypeName, "_")[1], | ||
| Hostname: p.Hostname, | ||
| ID: p.ID, | ||
| Sharded_cluster: strings.Split(p.ReplicaSetName, "-")[0] + "-" + strings.Split(p.ReplicaSetName, "-")[1], |
There was a problem hiding this comment.
Here is some more elegant way to cut the suffix, if it's really necessary:
Suggested change
| Sharded_cluster: strings.Split(p.ReplicaSetName, "-")[0] + "-" + strings.Split(p.ReplicaSetName, "-")[1], | |
| Sharded_cluster: strings.Join(strings.Split(p.ReplicaSetName, "-")[:2], "-"), |
measurer/base_measurer.go
Outdated
| Hostname: p.Hostname, | ||
| ID: p.ID, | ||
| Sharded_cluster: strings.Split(p.ReplicaSetName, "-")[0] + "-" + strings.Split(p.ReplicaSetName, "-")[1], | ||
| Project_name: strings.Split(p.UserAlias, "-")[0] + "-" + strings.Split(p.UserAlias, "-")[1], |
There was a problem hiding this comment.
Same here:
Suggested change
| Project_name: strings.Split(p.UserAlias, "-")[0] + "-" + strings.Split(p.UserAlias, "-")[1], | |
| Project_name: strings.Join(strings.Split(p.UserAlias, "-")[:2], "-"), |
| Hostname: p.Hostname, | ||
| ID: p.ID, | ||
| UserAlias: p.UserAlias + fmt.Sprintf(":%d", p.Port), | ||
| TypeName: strings.Split(p.TypeName, "_")[1], |
There was a problem hiding this comment.
Don't know if we depend on the full TypeName ATM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In base_measurer.go, using "mongodbatlas.Process" package derived additional labels as below,
TypeName: strings.Split(p.TypeName, "_")[1],
Sharded_cluster: strings.Split(p.ReplicaSetName, "-")[0] + "-" + strings.Split(p.ReplicaSetName, "-")[1],
Project_name: strings.Split(p.UserAlias, "-")[0] + "-" + strings.Split(p.UserAlias, "-")[1],