Fix predictor adapter load state dict to accept keyword arguments#1207
Merged
Conversation
Collaborator
Author
|
Seems like there is a new release around |
Collaborator
Author
|
Ayy eureka it works haha (I simply adapted our exports to If the tests pass, I'll simply merge this to fix related broken tests in other (active) branches! |
Collaborator
Author
|
This worked amazingly nice. I'll go ahead and merge this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytorch's model loading engine calls has changed andstrict=Trueis the hard default for a while (not sure what changed that the tests are breaking right now).Let's see how the tests work at #1206, this would confirm the suspicion!