[CF-4208] Add --name/--status filtering to on-prem application list - #3428
Draft
Paras Negi (paras-negi-flink) wants to merge 1 commit into
Draft
Conversation
Stacked on the --page-size PR. Add server-side filtering to `flink application list` via --name (supports a "*" suffix wildcard) and --status, composed into the CMF applications "filter" query (name=<value>,state=<value>). ListApplications gains a filter parameter that is applied via the SDK's .Filter(...) before pagination. An unrecognized --status prints a [WARN] to stderr but still queries, since the CMF server treats an unknown state as a no-match rather than an error. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
❌ Error getting contributor login(s). |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
New Features
--nameand--statusfilters to the on-prem (Confluent Platform / CMF)confluent flink application listcommand, to filter large environments server-side instead of "list everything then grep".Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Confluent Platform (CMF on-prem) only — filtering half of CF-4208; Confluent Cloud
flinkcommands are untouched.flink application listhad no filtering, so at scale the only pattern was "list everything then grep" (CF-4202). This adds server-side filtering:--name— by application name; supports a trailing*wildcard (e.g.--name my-app*).--status— by Flink job state (RUNNING,FINISHED,FAILED,CANCELED,RECONCILING,COMPLETED,UNKNOWN).Both compose into CMF's single generic
filterquery asname=<value>,state=<value>;ListApplicationsgains afilterargument applied before pagination. An unknown--statusprints a[WARN]to stderr but still queries, since CMF treats an unknown state as a no-match (matchingstatement list --status).Blast Radius
application list; with neither flag set, behavior is unchanged (nofilterparam). NoCmfClientInterface/mock change. Non-breaking, easy to revert.References
--page-sizeto on-prem Flink list commands #3424.Test & Review
TestBuildApplicationFilter: name / wildcard / status / combined composition (name=a*,state=RUNNING).--nameexact + wildcard,--statusmatch / no-match / invalid (asserts[WARN]+ empty), combined--name+--status; help golden regenerated.make lintclean.🤖 Generated with Claude Code