Skip to content

fix(inquirerer): handle empty filteredOptions in checkbox and autocomplete #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 1 commit into from
Dec 27, 2025
Merged

fix(inquirerer): handle empty filteredOptions in checkbox and autocomplete #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions packages/inquirerer/src/prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,18 @@ export class Inquirerer {

const updateFilteredOptions = (): void => {
filteredOptions = this.filterOptions(options, input);
// Clamp selectedIndex and startIndex when filtered results change
if (filteredOptions.length === 0) {
selectedIndex = 0;
startIndex = 0;
} else {
if (selectedIndex >= filteredOptions.length) {
selectedIndex = filteredOptions.length - 1;
}
if (startIndex > Math.max(0, filteredOptions.length - maxLines)) {
startIndex = Math.max(0, filteredOptions.length - maxLines);
}
}
};

const display = (): void => {
Expand Down Expand Up @@ -963,6 +975,10 @@ export class Inquirerer {
});

this.keypress.on(KEY_CODES.UP_ARROW, () => {
if (filteredOptions.length === 0) {
display();
return;
}
selectedIndex = selectedIndex > 0 ? selectedIndex - 1 : filteredOptions.length - 1;
if (selectedIndex < startIndex) {
startIndex = selectedIndex; // Scroll up
Expand All @@ -973,6 +989,10 @@ export class Inquirerer {
});

this.keypress.on(KEY_CODES.DOWN_ARROW, () => {
if (filteredOptions.length === 0) {
display();
return;
}
selectedIndex = (selectedIndex + 1) % filteredOptions.length;
if (selectedIndex >= startIndex + maxLines) {
startIndex = selectedIndex - maxLines + 1; // Scroll down
Expand All @@ -983,6 +1003,10 @@ export class Inquirerer {
});

this.keypress.on(KEY_CODES.SPACE, () => {
if (filteredOptions.length === 0 || !filteredOptions[selectedIndex]) {
display();
return;
}
// Map filtered index back to the original index in options
selections[options.indexOf(filteredOptions[selectedIndex])] = !selections[options.indexOf(filteredOptions[selectedIndex])];
display();
Expand Down Expand Up @@ -1089,6 +1113,10 @@ export class Inquirerer {

// Navigation
this.keypress.on(KEY_CODES.UP_ARROW, () => {
if (filteredOptions.length === 0) {
display();
return;
}
selectedIndex = selectedIndex - 1 >= 0 ? selectedIndex - 1 : filteredOptions.length - 1;
if (selectedIndex < startIndex) {
startIndex = selectedIndex; // Scroll up
Expand All @@ -1098,6 +1126,10 @@ export class Inquirerer {
display();
});
this.keypress.on(KEY_CODES.DOWN_ARROW, () => {
if (filteredOptions.length === 0) {
display();
return;
}
selectedIndex = (selectedIndex + 1) % filteredOptions.length;
if (selectedIndex >= startIndex + maxLines) {
startIndex = selectedIndex - maxLines + 1; // Scroll down
Expand Down