Skip to content

Conversation

@pyramation
Copy link
Contributor

@pyramation pyramation commented Dec 24, 2025

Summary

This PR makes two changes to clean up the publish configuration:

  1. Added .npmignore files to all 20 packages - Each file contains __tests__ to exclude test directories from npm publish
  2. Removed unused root dependencies and config:
    • Removed workspaces field from package.json (redundant with pnpm-workspace.yaml)
    • Removed unused devDependencies: cpy-cli, graphile-test, graphql-tag (only referenced in READMEs, no actual imports)
  3. Regenerated pnpm-lock.yaml to sync with the dependency removals

Review & Testing Checklist for Human

  • Run pnpm pack --dry-run in a package directory to confirm __tests__ is excluded from the tarball
  • Verify lerna commands still work without the workspaces field in package.json (lerna.json has "npmClient": "pnpm" so it should use pnpm-workspace.yaml)

Recommended test plan: Pick one package (e.g., packages/verify), run pnpm pack --dry-run and verify the output excludes __tests__/ but includes the expected files (deploy/, verify/, revert/, sql/, LICENSE, Makefile, README.md, pgpm.plan, *.control).

Notes

The .npmignore approach excludes __tests__ but doesn't explicitly whitelist only the desired files. Other files like jest.config.js will still be included in publish. If stricter filtering is needed, consider using the "files" field in each package's package.json instead.


Link to Devin run: https://app.devin.ai/sessions/8d0bb3e7eee3456788d7919f36fd1880
Requested by: Dan Lynch (@pyramation)

- Add .npmignore files to all 20 packages to exclude __tests__ directories
- Remove unused devDependencies: graphile-test, graphql-tag, cpy-cli
- Remove workspaces field (pnpm-workspace.yaml handles this)

Co-Authored-By: Dan Lynch <[email protected]>
@devin-ai-integration
Copy link

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@pyramation pyramation closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants