fix(prompts): add override and CI report contracts - #70
Merged
Conversation
Signed-off-by: ainetx <viator@via-net.org> Co-authored-by: Constructor Studio <291158726+constructor-studio[bot]@users.noreply.github.com> Studio-Generated-By: Constructor Studio Studio-Source-Repo: https://github.com/constructorfabric/studio Constructor-Fabric: https://github.com/constructorfabric Studio-Version: skill=1.0.0 Studio-Workflows: cf-prompting-planning,cf-explore,cf-prompting-gen,cf-prompting-ci,cf-prompting-review,cf-prompting-fix,cf-git-commit
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR updates multi-file PDSL authoring, prerequisite override and blocked-report routing, deterministic CI findings outputs, coding-fix terminal outcomes, and canonical completion envelopes based on actual written paths. ChangesWorkflow contracts and completion flows
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant FixWorkflow
participant AssumptionOverrideContract
participant FindingsRenderContract
participant CompletionUnit
FixWorkflow->>AssumptionOverrideContract: validate override and record assumptions
FixWorkflow->>FindingsRenderContract: render deterministic findings outputs
FindingsRenderContract-->>FixWorkflow: return ci-findings and report outputs
FixWorkflow->>CompletionUnit: provide written paths and report outputs
CompletionUnit-->>FixWorkflow: emit canonical completion envelope
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
code-ranker View diff report ↗🤖 Prompt for fix all with AIbaseline main @d311018 2026-07-24 03:37 UTC · updated 2026-07-24 03:44 UTC |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/studio/modules/coding-review-fix.md`:
- Around line 42-46: Reorder and tighten the continuation branches in the
review-fix flow so applied fixes cannot complete while findings remain or
GATE_STATUS is fail. Update CodingReviewOrFixComplete to require zero remaining
findings and a non-failing gate, and route remaining findings, deterministic
blockers, and the unset-gate manual-verification state before completion,
ensuring the manual-verification branch remains reachable regardless of
REVIEW_LOOP_REQUESTED.
In `@skills/studio/modules/runtime/blocked-report.md`:
- Around line 23-25: Update the missing_artifacts contract to include a
canonical artifact_or_gate identifier, or explicitly designate artifact_type as
its canonical alias. Ensure every producer of missing_artifacts populates that
identifier consistently so explicit overrides can target exact blocked artifacts
or gates.
- Around line 33-35: Clarify the suggested_next_skills precedence rules: when
the caller supplies an explicit suggested_next_skills list, preserve and use its
ordering for the primary recommendation; derive the list from the union of
missing_artifacts[].suggested_producers only when no explicit list is supplied.
Update the related requirement that currently mandates the union-derived
producer as the first entry.
In `@skills/studio/modules/write-docs-completion.md`:
- Around line 13-15: Update the completion-path handling in
skills/studio/modules/write-docs-completion.md (lines 13-15, with the related
emission logic at lines 21-23) and
skills/studio/modules/write-skills-completion.md (lines 13-15, with the related
emission logic at lines 23-25) to treat an empty path list, including [], as
unconfirmed. Require COMPLETION_PATHS_WRITTEN to be non-empty before setting
COMPLETION_PATHS_CONFIRMED or emitting doc-changes/skill-changes.
In `@workflows/coding-ci.md`:
- Line 63: Replace the ambiguous nested FINDINGS_REPORT.report_outputs
references with an explicit merge of the structured deterministic-report entry
and the top-level report_outputs state. Apply this in workflows/coding-ci.md:63,
workflows/documenting-ci.md:56, workflows/prompting-ci.md:66, and
workflows/prompting-fix.md:112, preserving the rendered ci-findings descriptor
in each terminal or post-fix validation payload.
In `@workflows/coding-fix.md`:
- Around line 59-61: Remove the REVIEW_FINDINGS_REMAINING == 0 condition from
the missing review-findings artifact rules in workflows/coding-fix.md lines
59-61 and workflows/documenting-fix.md lines 58-60, so supported zero-findings
reports are not classified as missing. Keep relevant-files-map validation
independent, requiring it whenever REVIEW_TARGET_PATHS is unset and findings are
supported with remaining findings.
In `@workflows/prompting-fix.md`:
- Around line 55-58: The REVIEW_FINDINGS_REPORT_STATE rules must require a
canonical review-findings report before setting supported. Remove or tighten the
fallback rules so objects with findings lists or arbitrary lists are not
accepted unless ReviewFindingsReport.report_type is review-findings; preserve
the unsupported fallback for non-unset reports that fail this validation.
- Around line 59-64: Ensure the missing_artifacts logic always includes a
non-overridable relevant-files-map whenever REVIEW_TARGET_PATHS is unset,
including when the findings report is missing, unsupported, or empty. Update the
affected conditional branches so an overridable review-findings entry cannot
activate FIX_PREREQUISITE_OVERRIDE_ACTIVE without the required target scope,
while preserving the existing findings-report requirements.
- Around line 68-69: Update the override-assumption setup near
FIX_PREREQUISITE_OVERRIDE_ACTIVE and AssumptionOverrideContract so the required
degraded-scope assumption is always appended whenever the override is active,
regardless of whether ASSUMPTIONS is unset, empty, or already populated.
Preserve existing assumptions and ensure the appended entry includes the
required artifact_or_gate, summary, and risk fields before running
AssumptionOverrideContract.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fcf79150-9928-481e-b31d-4478f59320c1
📒 Files selected for processing (18)
skills/studio/agents/cf-pdsl-author.mdskills/studio/modules/coding-review-fix.mdskills/studio/modules/runtime/assumption-override.mdskills/studio/modules/runtime/blocked-next-actions.mdskills/studio/modules/runtime/blocked-report.mdskills/studio/modules/runtime/ci-report-render.mdskills/studio/modules/runtime/findings-render.mdskills/studio/modules/runtime/thin-skill-contracts.mdskills/studio/modules/write-docs-completion.mdskills/studio/modules/write-skills-completion.mdworkflows/coding-ci.mdworkflows/coding-fix.mdworkflows/documenting-ci.mdworkflows/documenting-fix.mdworkflows/kit-ci.mdworkflows/kit-fix.mdworkflows/prompting-ci.mdworkflows/prompting-fix.md
Signed-off-by: ainetx <viator@via-net.org> Co-authored-by: Constructor Studio <291158726+constructor-studio[bot]@users.noreply.github.com> Studio-Generated-By: Constructor Studio Studio-Source-Repo: https://github.com/constructorfabric/studio Constructor-Fabric: https://github.com/constructorfabric Studio-Version: skill=1.0.0 Studio-Workflows: cf-prompting-review,cf-prompting-fix,cf-prompting-ci,cf-git-commit
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/studio/modules/coding-review-fix.md (1)
63-69: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winPass the reviewed scope into the deterministic-blocker next action.
The shared fix-outcome contract requires deterministic-blocker routing to provide the domain CI skill with
REVIEW_TARGET_PATHS,REVIEW_TARGET_SLICES, and gate/validation status. CallingNextActionsOfferwith onlycf-coding-cican rerun CI without the correct review scope.Proposed contract-aligned change
- RUN NextActionsOffer with cf-coding-ci marked (suggested) + SET NEXT_ACTION_PINNED_SKILL = cf-coding-ci + SET NEXT_ACTION_PAYLOAD = REVIEW_TARGET_PATHS, REVIEW_TARGET_SLICES, GATE_STATUS + RUN NextActionsOffer🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/studio/modules/coding-review-fix.md` around lines 63 - 69, Update UNIT CodingReviewFixOutcomeDeterministicBlockers so its NextActionsOffer invocation passes the reviewed scope through REVIEW_TARGET_PATHS and REVIEW_TARGET_SLICES, along with the applicable gate and validation status, while retaining cf-coding-ci as suggested and the existing blocker summary behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/studio/modules/coding-review-fix.md`:
- Around line 38-46: Add an explicit fallback after the
REVIEW_FINDINGS_REMAINING continuation branches in
CodingReviewFixOutcomeRemainingFindings: when the count remains unset because
the fix manifest and post-fix resolution payload are missing or malformed, route
execution to the existing blocked or verification-failure outcome instead of
allowing the workflow to stall.
---
Outside diff comments:
In `@skills/studio/modules/coding-review-fix.md`:
- Around line 63-69: Update UNIT CodingReviewFixOutcomeDeterministicBlockers so
its NextActionsOffer invocation passes the reviewed scope through
REVIEW_TARGET_PATHS and REVIEW_TARGET_SLICES, along with the applicable gate and
validation status, while retaining cf-coding-ci as suggested and the existing
blocker summary behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 53034f94-7767-4708-938a-37927a986605
📒 Files selected for processing (10)
skills/studio/modules/coding-review-fix.mdskills/studio/modules/runtime/blocked-report.mdskills/studio/modules/write-docs-completion.mdskills/studio/modules/write-skills-completion.mdworkflows/coding-ci.mdworkflows/coding-fix.mdworkflows/documenting-ci.mdworkflows/documenting-fix.mdworkflows/prompting-ci.mdworkflows/prompting-fix.md
🚧 Files skipped from review as they are similar to previous changes (8)
- workflows/coding-ci.md
- skills/studio/modules/write-skills-completion.md
- workflows/coding-fix.md
- workflows/prompting-ci.md
- skills/studio/modules/runtime/blocked-report.md
- skills/studio/modules/write-docs-completion.md
- workflows/documenting-fix.md
- workflows/prompting-fix.md
Signed-off-by: ainetx <viator@via-net.org> Co-authored-by: Constructor Studio <291158726+constructor-studio[bot]@users.noreply.github.com> Studio-Generated-By: Constructor Studio Studio-Source-Repo: https://github.com/constructorfabric/studio Constructor-Fabric: https://github.com/constructorfabric Studio-Version: skill=1.0.0 Studio-Workflows: cf-prompting-review,cf-prompting-fix,cf-prompting-ci,cf-git-commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit