Update libkrun library load on macOS #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EFI variant in 1.16.0 throws an error. Prefer the 1.15.1 non-EFI variant. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR implements a workaround for issue #51 by updating the libkrun library loading mechanism on macOS to prioritize the non-EFI variant (libkrun.dylib) over the EFI variant (libkrun-efi.dylib), which has loading issues in version 1.16.0.
Key Changes
- Modified library search to try multiple library names in priority order on macOS
- Updated Homebrew installation instructions to use
libkruninstead oflibkrun-efi - Added documentation about the compatibility issue with
libkrun-efi1.16.0
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/vm/libkrun/instance.go | Refactored library loading to search for multiple library names (libkrun.dylib first, then libkrun-efi.dylib as fallback) and updated error messages accordingly |
| README.md | Updated macOS installation instructions to use the slp/krun tap and libkrun package, with notes about the libkrun-efi compatibility issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akerouanton
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EFI variant for 1.16.0 causes #51. The non-EFI variant may be built in used or the 1.15.1 libkrun build works.
Workaround for #51. Ideally the EFI variant is fixed or an up to do non-EFI variant is available via Homebrew.
I explored building libkrun as part of the bake process, however, cross compiling within a Linux container is complex as it seems it would require a large licensed sdk.