feat: add notification mechanism for network lifecycle events #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vyasgun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vyasgun
force-pushed
the
pr/network-ready-notifications
branch
2 times, most recently
from
81d46df to
40ef47c
Compare
Introduces a channel-based notification sender that sends JSON messages over Unix domain sockets for key events: - Ready: network stack is ready for connections - ConnectionEstablished: VM connection accepted - HypervisorError: error during VM connection setup Signed-off-by: Gunjan Vyas <[email protected]>
vyasgun
force-pushed
the
pr/network-ready-notifications
branch
from
40ef47c to
6e003ff
Compare
vyasgun
commented
Oct 30, 2025
| } | ||
| log.Info("waiting for clients...") | ||
|
|
||
| notificationSender := notification.NewNotificationSender(config.NotificationSocket) |
Member
Author
There was a problem hiding this comment.
Initializing notificationSender here because NewNotificationSender always returns a valid object (a no-op sender when socket is empty), removing the need for nil checks at every Send() call.
vyasgun
force-pushed
the
pr/network-ready-notifications
branch
3 times, most recently
from
7d21c39 to
1bb5281
Compare
Send connection_established and connection_closed directly from the switch when MAC is learned or connection with the VM closes. Assisted-by: Claude (Anthropic AI) Signed-off-by: Gunjan Vyas <[email protected]>
vyasgun
force-pushed
the
pr/network-ready-notifications
branch
from
1bb5281 to
93258e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a channel-based notification sender that sends JSON messages over Unix sockets for VM lifecycle events: