Retract 1.10.0 tag #207
Merged
Retract 1.10.0 tag #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
If you tag a new version to make the module proxy pick it up it must also be retracted as well like in c/common So my assumption is that we must list two versions there |
mtrmac
suggested changes
Feb 26, 2025
There was a problem hiding this comment.
Yes, as @Luap99 says (and reference https://go.dev/ref/mod#go-mod-file-retract )
- The v1.10.0 retraction must be published in a tagged release
- That tagged release must be “latest”, maybe v1.10.1, to have effect
- … and therefore, v1.10.1 must also be retracted, in the v1.10.1 tag.
So:
- Merge a PR which retracts both v1.10.0 and v1.10.1
- Tag that commit with v1.10.1
- Hopefully, then Go will see
v0.9.0as the latest, and we can go on tagging v0.10.0 and the like.
A typo occurred when tagging the libhvee release so retracting that typo Signed-off-by: Brent Baude <[email protected]>
baude
force-pushed
the
retract1.10.0tag
branch
from
1ec8322 to
a43a581
Compare
Member
|
/lgtm |
Member
|
Looks like it worked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typo occurred when tagging the libhvee release so retracting that typo