fix create_guest_memory on aarch64 #445
Open
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppergrayxyz
requested review from
MatiasVara,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
- make default_guest_memory conditonal for x86_64 - update create_guest_memory to current signature - reorder aarch64 test case to mimic x86_64 test - fix dead code warning for Payload::None Fixes: containers#441 Signed-off-by: Pepper Gray <[email protected]>
peppergrayxyz
force-pushed
the
guest_memory
branch
from
5a2fd2f to
57b2a53
Compare
slp
reviewed
Nov 5, 2025
| let vm_resources = VmResources::default(); | ||
|
|
||
| let (guest_memory, _arch_memory_info, _shm_manager, _payload_config) = | ||
| create_guest_memory(128, &vm_resources, &Payload::Empty).unwrap(); |
Collaborator
There was a problem hiding this comment.
Thanks for taking some time to fix this!
I think it'd be better changing default_guest_memory above to create an empty VmResources (VmResources::default()) and creating the memory with an empty payload (Payload::Empty) so it can be used both in x86_64 and aarch64 tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #441