Add support for readonly FLAT/ZERO VMDK format #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsiangkao
requested review from
MatiasVara,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
hsiangkao
force-pushed
the
vmdk
branch
2 times, most recently
from
c961c4c to
0f2bd53
Compare
mtjhrc
reviewed
Nov 28, 2025
slp
reviewed
Nov 28, 2025
Collaborator
|
@hsiangkao LGTM, but please rebase on current upstream. |
Contributor
Author
Done. |
Collaborator
|
@hsiangkao please commit the changes to |
Currently, it's mainly used for EROFS to merge hundreds of sub-blobs (container image layers) into one block device to avoid having too many block devices (and it would even be impossible for virtio-mmio since legacy IRQs is much limited in libkrun). Why VMDK is useful? Since it seems to be the only standard and simple way to support one-single block device that consists of a collection of multiple file parts among popular virtualization products such as QEMU and VirtualBox. Update the `krun_add_disk2` API to specify the VMDK format: - KRUN_DISK_FORMAT_VMDK Signed-off-by: Gao Xiang <[email protected]>
Contributor
Author
Ah sorry, done. |
slp
approved these changes
Dec 5, 2025
Collaborator
slp
left a comment
slp
left a comment
There was a problem hiding this comment.
@hsiangkao Thanks, let's get it merged.
Thanks for your help, too @XanClic !
Contributor
Author
Many thanks for considering this feature too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see: containerd/nerdbox#30
Currently, it's mainly used for EROFS to merge hundreds of sub-blobs (container image layers) into one block device to avoid having too many block devices (and it would even be impossible for virtio-mmio since legacy IRQs is much limited in libkrun).
Why VMDK is useful? Since it seems to be the only standard and simple way to support one-single block device that consists of a collection of multiple file parts among popular virtualization products such as QEMU and VirtualBox.
Update the
krun_add_disk2API to specify the VMDK format: