Skip to content

Conversation

@inknos
Copy link
Contributor

@inknos inknos commented Sep 4, 2025

No description provided.

Signed-off-by: Nicola Sella <[email protected]>
@openshift-ci openshift-ci bot added the approved label Sep 4, 2025
@Luap99
Copy link
Member

Luap99 commented Sep 4, 2025

Note you also must add @Honny1 with (write?) permissions to this repo in the github settings to make him an actual "collaborator", ref #569 (comment)

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inknos
Copy link
Contributor Author

inknos commented Sep 4, 2025

Note you also must add @Honny1 with (write?) permissions to this repo in the github settings to make him an actual "collaborator", ref #569 (comment)

right, actually I believe he needs to be added to podman-py-maintainers, do you have perms?

cc @baude

@Luap99
Copy link
Member

Luap99 commented Sep 4, 2025

Note you also must add @Honny1 with (write?) permissions to this repo in the github settings to make him an actual "collaborator", ref #569 (comment)

right, actually I believe he needs to be added to podman-py-maintainers, do you have perms?

Yes I added him there, adding him to the team makes the most sense certainly.

@rhatdan
Copy link
Member

rhatdan commented Sep 4, 2025

/lgtm

@Honny1
Copy link
Member

Honny1 commented Sep 4, 2025

Thanks, everybody.

@openshift-merge-bot openshift-merge-bot bot merged commit 85bc956 into main Sep 4, 2025
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants