Move images to fedora 43 #1996

rhatdan · 2025-10-02T09:48:33Z

Summary by Sourcery

Build:

Bump Fedora base image from version 42 to 43 across all Containerfiles

sourcery-ai · 2025-10-02T09:48:40Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR standardizes all container definitions on Fedora 43 by updating the FROM directives in each Containerfile, including both builder and runtime stages for the intel-gpu image.

File-Level Changes

Change	Details	Files
Upgrade Fedora base image in intel-gpu Containerfile	Switch builder stage FROM quay.io/fedora/fedora:42 to :43 Switch final stage FROM quay.io/fedora/fedora:42 to :43	`container-images/intel-gpu/Containerfile`
Upgrade Fedora base image in remaining Containerfiles	Update FROM directive from quay.io/fedora/fedora:42 to :43 across other images	`container-images/asahi/Containerfile` `container-images/bats/Containerfile` `container-images/llama-stack/Containerfile` `container-images/ramalama-cli/Containerfile` `container-images/ramalama/Containerfile` `container-images/rocm-fedora/Containerfile` `container-images/rocm/Containerfile` `container-images/stable-diffusion/Containerfile`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gemini-code-assist · 2025-10-02T09:48:49Z

Summary of Changes

Hello @rhatdan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a systematic upgrade of the base operating system for multiple container images, transitioning them from Fedora 42 to Fedora 43. This update is crucial for ensuring that all containerized environments benefit from the latest security patches, performance improvements, and updated software packages available in the newer Fedora release, thereby maintaining a modern and secure foundation for the applications.

Highlights

Base Image Upgrade: All Containerfiles across various container images have been updated to use quay.io/fedora/fedora:43 as their base image, upgrading from the previous quay.io/fedora/fedora:42.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

gemini-code-assist

Code Review

This pull request aims to update the base images to Fedora 43. My review found a critical issue where one of the container builds will fail due to a hardcoded package version for Fedora 42 in a build script. This needs to be addressed to ensure all images build successfully with the new Fedora version.

gemini-code-assist · 2025-10-02T09:49:44Z

container-images/ramalama/Containerfile

@@ -1,4 +1,4 @@
-FROM quay.io/fedora/fedora:42
+FROM quay.io/fedora/fedora:43


Bumping the base image to Fedora 43 will cause the build for this container to fail. The script container-images/scripts/build_llama_and_whisper.sh, which is executed by this Containerfile, has a hardcoded dependency on a Fedora 42 package.

Specifically, in container-images/scripts/build_llama_and_whisper.sh, the dnf_install_mesa function attempts to install and version-lock mesa-vulkan-drivers-25.0.7-101.fc42 (lines 76 and 78). This package does not exist in Fedora 43 repositories.

Please update the script to use the correct package for Fedora 43 or make the package version dynamic.

rhatdan · 2025-10-02T10:29:07Z

@slp do we still need?

dnf_install_mesa() {
  if [ "${ID}" = "fedora" ]; then
    dnf copr enable -y slp/mesa-libkrun-vulkan
    dnf install -y mesa-vulkan-drivers-25.0.7-101.fc42 virglrenderer \
      "${vulkan_rpms[@]}"
    dnf versionlock add mesa-vulkan-drivers-25.0.7-101.fc42
  elif [ "${ID}" = "openEuler" ]; then
    dnf install -y mesa-vulkan-drivers virglrenderer "${vulkan_rpms[@]}"
  else # virglrenderer not available on RHEL or EPEL
    dnf install -y mesa-vulkan-drivers "${vulkan_rpms[@]}"
  fi

  rm_non_ubi_repos
}

Or are these available in fc43?

olliewalsh · 2025-10-02T15:51:25Z

@slp do we still need?

dnf_install_mesa() {
  if [ "${ID}" = "fedora" ]; then
    dnf copr enable -y slp/mesa-libkrun-vulkan
    dnf install -y mesa-vulkan-drivers-25.0.7-101.fc42 virglrenderer \
      "${vulkan_rpms[@]}"
    dnf versionlock add mesa-vulkan-drivers-25.0.7-101.fc42
  elif [ "${ID}" = "openEuler" ]; then
    dnf install -y mesa-vulkan-drivers virglrenderer "${vulkan_rpms[@]}"
  else # virglrenderer not available on RHEL or EPEL
    dnf install -y mesa-vulkan-drivers "${vulkan_rpms[@]}"
  fi

  rm_non_ubi_repos
}

Or are these available in fc43?

IIUC there were vulkan issues on mesa 25.1, I guess that's why it was pinned to 25.0. Can probably remove the version pin now.

^H^H^H nope, need to be 16k aligned for MacOS 385a992

slp · 2025-10-02T16:42:20Z

Or are these available in fc43?

Not yet, but can have the packages built tomorrow.

slp · 2025-10-03T15:14:35Z

The packages are ready in the COPR. Please apply this one:

diff --git a/container-images/scripts/build_llama_and_whisper.sh b/container-images/scripts/build_llama_and_whisper.sh
index d697f7e..44a7c81 100755
--- a/container-images/scripts/build_llama_and_whisper.sh
+++ b/container-images/scripts/build_llama_and_whisper.sh
@@ -73,9 +73,9 @@ dnf_install_s390_ppc64le() {
 dnf_install_mesa() {
   if [ "${ID}" = "fedora" ]; then
     dnf copr enable -y slp/mesa-libkrun-vulkan
-    dnf install -y mesa-vulkan-drivers-25.0.7-101.fc42 virglrenderer \
+    dnf install -y mesa-vulkan-drivers-25.2.3-101.fc43 virglrenderer \
       "${vulkan_rpms[@]}"
-    dnf versionlock add mesa-vulkan-drivers-25.0.7-101.fc42
+    dnf versionlock add mesa-vulkan-drivers-25.2.3-101.fc43
   elif [ "${ID}" = "openEuler" ]; then
     dnf install -y mesa-vulkan-drivers virglrenderer "${vulkan_rpms[@]}"
   else # virglrenderer not available on RHEL or EPEL

kpouget · 2025-10-06T15:30:36Z

I think the build system is currently broken after Sergio's update to the COPR repo:

+ dnf install -y mesa-vulkan-drivers-25.0.7-101.fc42 virglrenderer vulkan-headers vulkan-loader-devel vulkan-tools spirv-tools glslc glslang
Updating and loading repositories:
 Copr repo for mesa-libkrun-vulkan owne 100% |  22.6 KiB/s |  13.1 KiB |  00m01s
Repositories loaded.
Failed to resolve the transaction:
No match for argument: mesa-vulkan-drivers-25.0.7-101.fc42
You can try to add to command line:
  --skip-unavailable to skip unavailable packages
Error: building at STEP "RUN container-images/scripts/build_llama_and_whisper.sh ramalama": while running runtime: exit status 1

kpouget · 2025-10-10T08:10:19Z

any update on this?
the (MacOS, at least) Ramalama image can't be built until this is resolved

slp · 2025-10-10T08:49:49Z

This one needs to be merged to fix the COPR references.

kpouget · 2025-10-10T08:54:49Z

hum, nevermind, it has been resolved in this PR (by updating the mesa-vulkan-drivers version)

Installing:
 glslang             aarch64 15.3.0-1.fc42    updates                                                  3.1 MiB
 glslc               aarch64 2025.2-1.fc42    updates                                                  3.1 MiB
 mesa-vulkan-drivers aarch64 25.2.3-101.fc42  copr:copr.fedorainfracloud.org:slp:mesa-libkrun-vulkan  94.1 MiB
 spirv-tools         aarch64 2025.2-2.fc42    updates                                                  1.1 MiB
 virglrenderer       aarch64 1.1.0-2.fc42     fedora                                                   1.2 MiB
 vulkan-headers      noarch  1.4.313.0-1.fc42 updates                                                 30.9 MiB
 vulkan-loader-devel aarch64 1.4.313.0-1.fc42 updates                                                  8.0 KiB
 vulkan-tools        aarch64 1.4.313.0-1.fc42 updates                                                  1.5 MiB

Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan · 2025-10-28T13:17:46Z

I was told Fedora 43 is releasing today.

rhatdan requested review from bmahabirbu, cgruver, engelmi, jhjaggars, maxamillion and swarajpande5 as code owners October 2, 2025 09:48

sourcery-ai bot approved these changes Oct 2, 2025

View reviewed changes

gemini-code-assist bot reviewed Oct 2, 2025

View reviewed changes

rhatdan changed the title ~~Move images to fedora 43~~ [WIP] Move images to fedora 43 Oct 2, 2025

rhatdan force-pushed the f43 branch from c23e98a to 5d0e732 Compare October 3, 2025 20:39

rhatdan force-pushed the f43 branch from 5d0e732 to 786c062 Compare October 12, 2025 07:57

Move images to fedora 43

6e43168

Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan force-pushed the f43 branch from 786c062 to 6e43168 Compare October 28, 2025 13:17

rhatdan changed the title ~~[WIP] Move images to fedora 43~~ Move images to fedora 43 Oct 28, 2025

		@@ -1,4 +1,4 @@
		FROM quay.io/fedora/fedora:42
		FROM quay.io/fedora/fedora:43

Move images to fedora 43 #1996

Are you sure you want to change the base?

Move images to fedora 43 #1996

Uh oh!

Conversation

rhatdan commented Oct 2, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot commented Oct 2, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

rhatdan commented Oct 2, 2025

Uh oh!

olliewalsh commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slp commented Oct 2, 2025

Uh oh!

slp commented Oct 3, 2025

Uh oh!

kpouget commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kpouget commented Oct 10, 2025

Uh oh!

slp commented Oct 10, 2025

Uh oh!

kpouget commented Oct 10, 2025

Uh oh!

rhatdan commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rhatdan commented Oct 2, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Oct 2, 2025 •

edited

Loading

olliewalsh commented Oct 2, 2025 •

edited

Loading

kpouget commented Oct 6, 2025 •

edited

Loading