-
Notifications
You must be signed in to change notification settings - Fork 276
konflux: prefetch python dependencies when building -rag images #2094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mikebonnet
wants to merge
2
commits into
main
Choose a base branch
from
konflux-rag-deps-prefetch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konflux prefetch (Hermeto) supports downloading packages from indexes other than pypi, via the --index-url option. However, only one --index-url may be specified per requriements file and all packages in that file will be retrieved from that index. Split the requirements files generated by "uv pip compile" into separate files by index. Generate requirements files for build dependencies, as required by Hermeto. Signed-off-by: Mike Bonnet <[email protected]>
Contributor
Reviewer's GuideThis PR integrates Hermeto-based prefetching into the -rag image build process by overhauling Makefile rules for uv pip compilation, splitting and naming requirement files per index, updating the build script for offline installation with gguf fixups, and injecting prefetch configuration into Tekton pipelines. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Konflux supports prefetching dependencies via Hermeto. This allows for creation of more accurate SBOMs and source containers, and will improve the performance and reliability of builds when caching is implemented. When using prefetched dependencies (indicated by PIP_FIND_LINKS being set), run "uv pip install" in offline mode. Signed-off-by: Mike Bonnet <[email protected]>
6cd28b2 to
c365af7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Konflux supports prefetching dependencies via Hermeto. This allows for creation of more accurate SBOMs and source containers, and will improve the performance and reliability of builds when caching is implemented.
Retrieve dependencies for the -rag images using prefetch, and run the
uv pip installcommand offline.Summary by Sourcery
Enable prefetching Python dependencies for RAG container images using Hermeto and uv to generate accurate SBOMs and support offline pip installs in CI builds.
New Features:
Enhancements: