Skip to content

chore(repo): Update signing process to Cosign#80

Open
lusu007 wants to merge 2 commits intomainfrom
fix/signing-process
Open

chore(repo): Update signing process to Cosign#80
lusu007 wants to merge 2 commits intomainfrom
fix/signing-process

Conversation

@lusu007
Copy link
Copy Markdown
Member

@lusu007 lusu007 commented Apr 2, 2026

Fix signing step in actions. The current signing step is broken because it is not compatible with the newest Helm release.

Additional Context

N/A

Checklist

  • The chart version in Chart.yaml has been updated according to semantic versioning (semver).
  • All variables are documented in the Chart's values.yaml and README.md files.
  • The pull request title meets the Conventional Commits specification and includes the chart name, for example: feat(chart-name): Add replica support

@lusu007 lusu007 requested review from Copilot and meyfa April 2, 2026 13:37
@lusu007 lusu007 requested a review from a team as a code owner April 2, 2026 13:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the chart-signing approach in the release workflow to use Cosign (keyless/OIDC) instead of the deprecated/broken helm-sigstore flow, and aligns repository documentation with the new verification method.

Changes:

  • Replace helm-sigstore plugin usage with Cosign installation and cosign sign in the release workflow.
  • Add required GitHub Actions OIDC permission (id-token: write) and update README verification instructions to use cosign verify.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
README.md Updates OCI chart verification guidance to Cosign keyless/OIDC.
.github/workflows/release.yml Switches signing/upload flow to Cosign and adjusts workflow permissions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
@lusu007 lusu007 force-pushed the fix/signing-process branch 2 times, most recently from 539f162 to 3e45701 Compare April 2, 2026 15:48
@meyfa meyfa force-pushed the fix/signing-process branch from 3e45701 to 1161749 Compare April 5, 2026 09:16
@meyfa meyfa changed the title fix: update signing process chore(repo): Update signing process to Cosign Apr 5, 2026
@meyfa meyfa requested a review from Copilot April 5, 2026 09:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml Outdated
Comment thread README.md
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
@lusu007 lusu007 force-pushed the fix/signing-process branch from 7708f9a to 2708026 Compare April 6, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants