chore: normalize Node version declarations to .nvmrc source of truth [AIS-54] - #46
ethan ozelius (ethan-ozelius-contentful) wants to merge 4 commits into
Conversation
|
Need to verify if this package uses semantic-versioning. Since we're dropping support for node <= 20, that would be a breaking change. Confirmed, this is going to require a breaking change and new major version. https://github.com/contentful/actions-app-deploy/releases v1.1.0 |
|
tsconfig.json should probably also match same version as
|
d6a1085 to
bd837f9
Compare
bd837f9 to
376d8fa
Compare
| default: true | ||
| runs: | ||
| using: 'node20' | ||
| using: 'node22' |
There was a problem hiding this comment.
TIL the actions runtime doesn't actually support 22 😿 maybe we go with node24 (since we are targeting Node 22+ APIs)?
There was a problem hiding this comment.
I'm 100% ok with going with 24. What do you mean exactly that the actions runtime doesn't support 22?
There was a problem hiding this comment.
check this out https://docs.github.com/en/actions/reference/workflows-and-actions/metadata-syntax#runsusing-for-javascript-actions
github skipped Node 22 for custom JavaScript actions 💀
the runs.using parameter only accepts node20 or node24. they announced in a changelog last fall that they were migrating straight from 20 to 24, so if we put node22 in there, the runner will throw an error.
There was a problem hiding this comment.
Wow, ok didn't see that coming either.
I'll update to 24
- node 24
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 participants
This PR was generated by ai-repo-migrator as part of the fleet-wide Node normalization initiative (AIS-54).
What changed
.nvmrcis now the single source of truth for the Node versionnode-version-file: .nvmrcinstead of a hardcoded versionARG NODE_VERSIONsourced from.nvmrcengines.nodeandvolta.nodeinpackage.jsonare aligned to the same versionChanges:
Confidence: 🟡 Medium
Attention files: action.yml, tsconfig.json, .nvmrc
Why
Collapsing ~2.7 declaration sites per repo to one means future Node CVE bumps are a single-file change per repo, opened automatically by Renovate. See AIS-54 for full context.