chore: add changelog entry for PR #9275 #9278
Conversation
Move error tracking logic to separate module to break circular dependency between index.ts and exit.ts. This was causing esbuild to generate invalid code with misplaced await keywords. - Create new errorTracking.ts module - Move hasUnhandledError flag and related functions to errorTracking.ts - Update imports in index.ts and exit.ts to use new module Co-authored-by: nate <[email protected]>
Co-authored-by: peter-parker <[email protected]> Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <[email protected]>
continue-development-app
bot
requested review from
RomneyDa
and removed request for
a team
dosubot
bot
added
the
size:XS
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
📚 Documentation UpdateI've created PR #9279 with documentation updates for the error handling improvements. The documentation includes:
These changes ensure users understand how to properly use exit codes in automation workflows and how to debug issues when they occur. cc: This addresses the documentation needs for PR #9275's error handling improvements. |
sestinj
force-pushed
the
nate/exit-with-error-on-unhandled-exceptions
branch
from
0788183 to
635aa42
Compare
dosubot
bot
added
size:M
…or handling - Increase waitForNextRender timeout from 500ms to 1000ms for slower CI environments (especially macOS) - Increase waitForCondition default timeout from 2000ms to 5000ms - Add error throwing to waitForCondition when timeout is reached - Update special characters test to use waitForCondition instead of waitForNextRender This fixes failing tests on macOS Node 18: - 'handles special characters in input without crashing [REMOTE MODE]' - 'filters slash commands when typing /log [LOCAL MODE]' Co-authored-by: peter-parker <[email protected]> Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <[email protected]>
|
Fixed macOS test flakiness by increasing timeouts in test helpers. The failing tests should now pass. |
Co-authored-by: peter-parker <[email protected]> Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <[email protected]>
Summary of ChangesThis PR fixes the failing macOS test on Node 18 by addressing test timing issues: Changes Made:
Tests Fixed:
Root Cause:The TUI (Terminal UI) rendering in the Ink framework takes longer on macOS CI runners than on other platforms. The tests were checking the frame content before the UI had finished rendering, causing them to see the frame border ( The fix ensures tests wait for the actual content to appear before making assertions. Note: The PR Checks workflow may require approval from a maintainer to run since it includes test file changes. |
This PR adds a changelog entry for PR #9275.
This agent session was co-authored by peter-parker and Continue.
Summary by cubic
Add a changelog entry for PR #9275 to document the new behavior for unhandled errors. It notes that the process now exits with a non-zero code, and also fixes a CLI build issue by moving error tracking to its own module and stabilizes macOS tests with longer timeouts.
Written for commit 6bb97c7. Summary will update automatically on new commits.