Skip to content

Fix item detail for datagrid nested in another component #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radimvaculik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix item detail for datagrid nested in another component #1300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion assets/plugins/features/item-detail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ export class ItemDetailPlugin implements DatagridPlugin {
onDatagridInit(datagrid: Datagrid): boolean {
datagrid.el.querySelectorAll<HTMLElement>("[data-toggle-detail-grid]")
.forEach((el) => {
if (el.getAttribute("data-toggle-detail-grid") !== datagrid.name) return;
// datagrid.name comes from data-datagrid-name, which holds the component full name.
// data-toggle-detail-grid only holds the plain name, so it never matches for a datagrid
// nested in another component - prefer the full name attribute.
const gridName = el.getAttribute("data-toggle-detail-grid-fullname")
?? el.getAttribute("data-toggle-detail-grid");

if (gridName !== datagrid.name) return;
const toggleId = el.getAttribute("data-toggle-detail")!;


Expand Down
Loading