fix: take maxlength from $maxLength instead of $cols

[dakorpar]

Closes #104.

The bug

BootstrapContainerTrait::addText() guarded on $maxLength but then wrote $cols into the attribute:

if ($maxLength !== null) {
    $comp->setHtmlAttribute('maxlength', $cols);
}

So addText('name', 'Name', 10, 50) rendered maxlength="10" — the maximum length of the value was decided by the visual width of the input, and the $maxLength that was actually asked for never reached the HTML. Passing $maxLength without $cols rendered maxlength="".

addPassword() delegates to addText(), so it carried the same bug.

The fix

$maxLength now goes through the TextInput constructor, which is how Nette\Forms\Container::addText() applies it, and $cols keeps setting the cols attribute on its own.

Also in here

addEmail() never applied its $maxLength. It takes int $maxLength = 255 and then called addText($name, $label) with the label only, so the argument was silently dropped — same defect, same two lines of code. It now passes the value on.

This one is a visible output change: every field built with addEmail() starts rendering maxlength="255" (or whatever was passed) where it previously rendered no maxlength at all. That is what Nette\Forms\Container::addEmail() has always produced, and the alternative is leaving a documented parameter that does nothing — flagging it since it lands in rendered HTML for existing users, and this branch is aimed at the next major anyway.

The @param int|null $cols ignored / $maxLength ignored notes on addText() and addTextArea() described neither the old nor the new behaviour — both arguments have always been written to attributes — so they now say what the arguments do.

Not changed: addText() renders $cols as a cols attribute, while Nette renders it as size (cols is a <textarea> attribute, not an <input> one). That is a separate pre-existing divergence, it is not what #104 reports, and correcting it would silently rewrite the HTML of every field that passes $cols — worth its own issue if you want it aligned.

Tests

Five tests in tests/Traits/BootstrapContainerTraitTest.php covering maxlength from $maxLength alongside cols, $maxLength without $cols, $cols alone rendering no maxlength, addPassword() passing it through, and addEmail() applying both its default and an explicit value. Four of the five fail on master.

make tests (163 tests, 250 assertions), make phpstan and make cs all pass. No rendering fixture under tests/data/ changed — none of them build an email field.

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (87fa3b3) to head (74fbec8).

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #130      +/-   ##
============================================
+ Coverage     97.05%   97.25%   +0.19%     
+ Complexity      309      308       -1     
============================================
  Files            25       25              
  Lines           986      984       -2     
============================================
  Hits            957      957              
+ Misses           29       27       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.