Skip to content

fix: resolve PHPStan errors blocking master CI #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f3l1x merged 8 commits into from
May 22, 2026
Merged

fix: resolve PHPStan errors blocking master CI #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7d17ca0
fix: narrow Router::resolve() return type to string
f3l1x May 22, 2026
87b28e0
fix: silence PHPStan on Compiler::getExtensions(interface)
f3l1x May 22, 2026
458046f
chore: bump phpstan to ^2.1 and related extensions to ^2.0
f3l1x May 22, 2026
4438685
fix(di): type extension config as array shape and avoid mutating $thi…
f3l1x May 22, 2026
850caee
fix(loaders): validate id/message column types from DB rows
f3l1x May 22, 2026
e5e23b4
fix(types): narrow mixed inputs in resolver, helpers and Latte filter
f3l1x May 22, 2026
98d804b
fix(translator): narrow mixed parameters in translate() and tighten k…
f3l1x May 22, 2026
f9e9625
fix(ci): support phpstan-lowest wording and satisfy CS sniff
f3l1x May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@
"nette/tester": "^2.3.1",
"ninjify/nunjuck": "^0.4.0",
"ninjify/qa": "^0.13",
"phpstan/phpstan": "^1.8",
"phpstan/phpstan-deprecation-rules": "^1.0",
"phpstan/phpstan-nette": "^1.0",
"phpstan/phpstan-strict-rules": "^1.1",
"phpstan/phpstan": "^2.1",
"phpstan/phpstan-deprecation-rules": "^2.0",
"phpstan/phpstan-nette": "^2.0",
"phpstan/phpstan-strict-rules": "^2.0",
"psr/log": "^1.1|^2.0|^3.0",
"tracy/tracy": "^2.8"
},
Expand Down
7 changes: 3 additions & 4 deletions phpstan.lowest.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ parameters:
excludePaths:
- src/Latte/TranslatorExtension.php
- src/Latte/Nodes/*
reportUnmatchedIgnoredErrors: false
ignoreErrors:
-
count: 2
Expand All @@ -24,10 +25,9 @@ parameters:

-
message: """
#^Fetching class constant class of deprecated class Nette\\\\Localization\\\\ITranslator\\:
#^Fetching class constant class of deprecated (class|interface) Nette\\\\Localization\\\\ITranslator\\:
use Nette\\\\Localization\\\\Translator$#
"""
count: 2
path: src/DI/TranslationExtension.php

-
Expand Down Expand Up @@ -64,8 +64,7 @@ parameters:

-
message: """
#^Fetching class constant class of deprecated class Nette\\\\Bridges\\\\ApplicationLatte\\\\ILatteFactory\\:
#^Fetching class constant class of deprecated (class|interface) Nette\\\\Bridges\\\\ApplicationLatte\\\\ILatteFactory\\:
use Nette\\\\Bridges\\\\ApplicationLatte\\\\LatteFactory$#
"""
count: 1
path: src/DI/TranslationExtension.php
11 changes: 9 additions & 2 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ parameters:
message: '#^Variable property access on object\.$#'
path: 'src/Loaders/Doctrine.php'

# upstream Finder iteration types vary between phpstan-nette versions;
# the instanceof guard is needed for phpstan-lowest but redundant here.
-
message: '#^Instanceof between Nette\\Utils\\FileInfo and SplFileInfo will always evaluate to true\.$#'
count: 1
path: src/DI/TranslationExtension.php

-
count: 2
message: '#^Comparison operation "\<" between \d+ and \d+ is always false\.$#'
Expand All @@ -38,15 +45,15 @@ parameters:
# -------------------------------------------------------------------
-
message: """
#^Fetching class constant class of deprecated interface Nette\\\\Bridges\\\\ApplicationLatte\\\\ILatteFactory\\:
#^Access to constant on deprecated interface Nette\\\\Bridges\\\\ApplicationLatte\\\\ILatteFactory\\:
use Nette\\\\Bridges\\\\ApplicationLatte\\\\LatteFactory$#
"""
count: 1
path: src/DI/TranslationExtension.php

-
message: """
#^Fetching class constant class of deprecated interface Nette\\\\Localization\\\\ITranslator\\:
#^Access to constant on deprecated interface Nette\\\\Localization\\\\ITranslator\\:
use Nette\\\\Localization\\\\Translator$#
"""
count: 2
Expand Down
4 changes: 1 addition & 3 deletions src/DI/Helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
namespace Contributte\Translation\DI;

use Contributte\Translation\Exceptions\InvalidState;
use Nette\DI\Definitions\Definition;
use Nette\DI\Definitions\Reference;
use Nette\DI\Definitions\Statement;

class Helpers
Expand All @@ -17,7 +15,7 @@ class Helpers
public static function unwrapEntity(Statement|string $input): string
{
if ($input instanceof Statement) {
/** @var class-string|Reference|Definition|mixed[] $entity */
/** @var class-string|null $entity */
$entity = $input->getEntity();
if (is_string($entity)) {
return $entity;
Expand Down
Loading
Loading