-
-
Notifications
You must be signed in to change notification settings - Fork 801
Feature: Add support for XEP-0444 Message Reactions #3906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature: Add support for XEP-0444 Message Reactions #3906
Conversation
e2289f4 to
cac7f22
Compare
|
@marcellintacite , did you see that it is possible to add «custom emojis» in the ConverseJS emoji picker? (see bellow for an explanation). I think those emojis should not be selectable as a message reaction. With this feature, you can link a code name (for example |
|
I thinks there are 2 other missing things in your implementation: Discovering supportConverseJS must declare to other client that it handles message reactions, by adding the feature The XEP says it MUST be implemented. Also, if you are chatting with a user (in a 1 to 1 conversation) that does not support this feature, maybe we should not display the action in the chatbox. Restricted reactionsThe XEP allow some clients or MUC to limit the set of supported emojis. See https://xmpp.org/extensions/xep-0444.html#disco-restricted So, you should check if there is such limitation (for a user in 1 to 1 conversations, and for the MUC in rooms), and filter the emoji picker. |
|
@marcellintacite: Have you seen @JohnXLivingston comments? |
Yes, i am working on it |
|
@marcellintacite: Good :) |
Alright , thanks. I am sorry i didn't remember. I'll do |
…estricted reactions
…estricted reactions
I added a support for them |
can you check my implementation please |
What do you mean by "added a support for them"? I can't find the related code. |
Yeah, the XEP compliance seems OK now :) |
…ction between standard and custom emojis via a new filter prop.
Thanks , |
Feature: Add support for XEP-0444 Message Reactions
Description
This PR implements XEP-0444: Message Reactions, allowing users to react to messages with emojis. It introduces a new plugin (
reactions) that handles the UI for picking reactions, displaying them on messages, and managing the underlying XMPP stanza logic.Key Changes
1. New Plugin:
reactionssrc/plugins/reactions/.<reaction>elements from message stanzas.urn:xmpp:reactions:0).2. UI Components
converse-reaction-picker):3. Technical Details
src/shared/chat/styles/emoji.scss) to ensure consistency between the chat input and the reaction picker.Screenshots / Video
emoji_converse.mp4
This still a Draft
CHANGES.mddocument it in
docs/source/configuration.rstwith
make checkor you can run them in the browser by runningmake serve