-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(service): add usesend configuration file and Remove unused unsend SVG #6997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
Hey, there is already an PR (#6606) for this exact same change and it got everything working but need minor changes. We will wait some more time for that PR author to implement the requested change, if they didn't respond then we can consider this PR. |
Sorry i did not check... Will do next time ! I updated the docs, adding SMTP documentation also |
|
? @Cinzya |
She probably thought its a UI related PR after reading the first part of the Title "Remove unused svg" xD Next time please start the title like |
|
Hi @yipfram! 👋 It appears to us that you are either adding a new service or making changes to an existing one. Coolify Docs Repository: https://github.com/coollabsio/coolify-docs |
|
Fixed title |
|
BTW, if this PR (#6606) is not changed and we end up using mine, i'll probably change the Cert system, which can make this template click and deploy... For now you have to make changes in the server proxy and compose file... That's too complicated if we can just attach let'sencrypt... But Idk if this works for everyone (idk how those work...) |
|
Hey @yipfram thanks for the PR, for now I am putting this PR on Hold since that other PR author responded + implemented some changes (waiting to implement few more). The changes on this PR for the usesend.yaml is same as the other PR, so let's wait and see if that PR author addresses my questions + provides a way to test the changes - if they don't then we can merge this one (I may forget this PR so feel free to ping me here or in discord after 2 weeks of this comment) |
|
Ok, in the meantime I'll check the other cert system and see how this can work |
|
Could we make this work? @ShadowArcanist coolify/templates/compose/usesend-with-smtp.yaml Lines 43 to 54 in c1e8986
Like Letsencrypt |
Sadly I have little to no experience with email related stuff so I can't suggest/recommend anything here without testing + understanding stuffs on my own |
|
Basically it works, the only question is how you collect the certs for the smtp server. I don't think it's related to email stuff |
I think you can simply map the |
|
Acme can work in the place of cert and key file? Sorry I'm on mobile now, I can't give an example snippet |
I just checked it on my dev instance and we can't use acme.json if we need a cert and key files T-T, so we may need something like traefik cert dumper |
|
Ok, any way we could attach it to this docker compose? (Not the proxy one) |
I think it's only needed for the proxy to work, if they are not using the usesend proxy then no need for certs (I maybe wrong here) |
Changes