Skip to content

Sync repo templates ⚙ - #2299

Merged
prestist merged 1 commit into
coreos:mainfrom
coreosbot-releng:repo-templates
Aug 24, 2026
Merged

Sync repo templates ⚙#2299
prestist merged 1 commit into
coreos:mainfrom
coreosbot-releng:repo-templates

Conversation

@coreosbot-releng

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cb5ea39a-e3bf-4161-a9f2-95b00f565aa0

📥 Commits

Reviewing files that changed from the base of the PR and between 9e2b242 and d1f90de.

📒 Files selected for processing (2)
  • .github/workflows/container-rebuild.yml
  • .github/workflows/container.yml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (9)
  • GitHub Check: Test (1.25.x)
  • GitHub Check: Build container image
  • GitHub Check: Shellcheck
  • GitHub Check: Test (1.26.x)
  • GitHub Check: Test ignition-validate (1.26.x, macos-latest)
  • GitHub Check: Build butane container image
  • GitHub Check: Test ignition-validate (1.26.x, windows-latest)
  • GitHub Check: Check binary size
  • GitHub Check: tmt-tests
⚠️ CI failures not shown inline (2)

GitHub Actions: Release notes / 0_Require release note.txt: Sync repo templates ⚙

Conclusion: failure

View job details

##[group]Run set -euo pipefail
 �[36;1mset -euo pipefail�[0m
 �[36;1mif [ -n "skip-notes" ]; then�[0m
 �[36;1m    # Don't trust the label list in the event metadata, since runs�[0m
 �[36;1m    # can be scheduled out of order and the list might be stale.�[0m
 �[36;1m    label=$(curl --no-progress-meter \�[0m
 �[36;1m        -H "Accept: application/vnd.github+json" \�[0m
 �[36;1m        -H "Authorization: token ***" \�[0m
 �[36;1m        "https://api.github.com/repos/coreos/ignition/pulls/2299" |�[0m
 �[36;1m        jq '.labels[] | select(.name == "skip-notes")')�[0m
 �[36;1m    if [ -n "${label}" ]; then�[0m
 �[36;1m        echo "PR has skip-notes label; skipping"�[0m
 �[36;1m        exit 0�[0m
 �[36;1m    fi�[0m
 �[36;1mfi�[0m
 �[36;1mdiffinfo=$(curl --no-progress-meter \�[0m
 �[36;1m    -H "Accept: application/vnd.github+json" \�[0m
 �[36;1m    -H "Authorization: token ***" \�[0m
 �[36;1m    "https://api.github.com/repos/coreos/ignition/compare/9e2b24287eab4e7a4c9fe1a79e78ea43e9db0f05...d1f90de7173e20c804fab4510a081e2ef7b3d17d" |�[0m
 �[36;1m    jq '.files[] | select(.filename == "docs/release-notes.md")')�[0m
 �[36;1mif [ -z "${diffinfo}" ]; then�[0m
 �[36;1m    echo "Found no changes to docs/release-notes.md."�[0m
 �[36;1m    if [ -n "skip-notes" ]; then�[0m
 �[36;1m        echo "To ignore, add skip-notes label to PR."�[0m
 �[36;1m    fi�[0m
 �[36;1m    exit 1�[0m
 �[36;1mfi�[0m
 �[36;1mecho "Found change to docs/release-notes.md."�[0m
 shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
 ##[endgroup]
 Found no changes to docs/release-notes.md.
 To ignore, add skip-notes label to PR.
 ##[error]Process completed with exit code 1.

GitHub Actions: Release notes / Require release note: Sync repo templates ⚙

Conclusion: failure

View job details

##[group]Run set -euo pipefail
 �[36;1mset -euo pipefail�[0m
 �[36;1mif [ -n "skip-notes" ]; then�[0m
 �[36;1m    # Don't trust the label list in the event metadata, since runs�[0m
 �[36;1m    # can be scheduled out of order and the list might be stale.�[0m
 �[36;1m    label=$(curl --no-progress-meter \�[0m
 �[36;1m        -H "Accept: application/vnd.github+json" \�[0m
 �[36;1m        -H "Authorization: token ***" \�[0m
 �[36;1m        "https://api.github.com/repos/coreos/ignition/pulls/2299" |�[0m
 �[36;1m        jq '.labels[] | select(.name == "skip-notes")')�[0m
 �[36;1m    if [ -n "${label}" ]; then�[0m
 �[36;1m        echo "PR has skip-notes label; skipping"�[0m
 �[36;1m        exit 0�[0m
 �[36;1m    fi�[0m
 �[36;1mfi�[0m
 �[36;1mdiffinfo=$(curl --no-progress-meter \�[0m
 �[36;1m    -H "Accept: application/vnd.github+json" \�[0m
 �[36;1m    -H "Authorization: token ***" \�[0m
 �[36;1m    "https://api.github.com/repos/coreos/ignition/compare/9e2b24287eab4e7a4c9fe1a79e78ea43e9db0f05...d1f90de7173e20c804fab4510a081e2ef7b3d17d" |�[0m
 �[36;1m    jq '.files[] | select(.filename == "docs/release-notes.md")')�[0m
 �[36;1mif [ -z "${diffinfo}" ]; then�[0m
 �[36;1m    echo "Found no changes to docs/release-notes.md."�[0m
 �[36;1m    if [ -n "skip-notes" ]; then�[0m
 �[36;1m        echo "To ignore, add skip-notes label to PR."�[0m
 �[36;1m    fi�[0m
 �[36;1m    exit 1�[0m
 �[36;1mfi�[0m
 �[36;1mecho "Found change to docs/release-notes.md."�[0m
 shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
 ##[endgroup]
 Found no changes to docs/release-notes.md.
 To ignore, add skip-notes label to PR.
 ##[error]Process completed with exit code 1.
🔇 Additional comments (2)
.github/workflows/container-rebuild.yml (1)

64-64: LGTM!

.github/workflows/container.yml (1)

60-60: LGTM!


📝 Walkthrough

Walkthrough

Both Butane container workflows now use the dedicated QUAY_AUTH_BUTANE secret for image authentication.

Changes

Butane registry authentication

Layer / File(s) Summary
Update Butane workflow credentials
.github/workflows/container-rebuild.yml, .github/workflows/container.yml
The Butane image build and publishing steps now read registry credentials from secrets.QUAY_AUTH_BUTANE.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d1f90

This PR makes a small repository workflow synchronization update, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: coreosbot

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes the template synchronization but does not follow the required subsystem: lowercase description format. Use a title such as *: sync repository templates with a lowercase description and no trailing period.
Commit Message Convention ⚠️ Warning The sole non-merge PR commit is Sync repo templates ⚙; it lacks subsystem: and starts with uppercase Sync, so it violates the required format. Amend the subject to include a subsystem and lowercase imperative description with no final period, for example ci: sync repo templates.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description explains that the pull request synchronizes repository templates from the specified source commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Binary size report (bin/amd64/ignition)

Size
Base (main) 33MiB
PR (#2299) 33MiB
Delta +0B (0.00%)

@prestist prestist added the skip-notes This PR does not need release notes label Aug 21, 2026
@prestist
prestist enabled auto-merge August 24, 2026 17:04
@prestist
prestist merged commit ba6a9a6 into coreos:main Aug 24, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-notes This PR does not need release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants