fix: cleanup in priority nonce mempool #25563
Open
+45
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
force-pushed
the
thomas/fix-priority-nonce
branch
from
e2c5dc5 to
c254a83
Compare
thomas-nguy
force-pushed
the
thomas/fix-priority-nonce
branch
from
c254a83 to
26a74c7
Compare
thomas-nguy
commented
Nov 17, 2025
|
|
||
| iter := mp.Select(ctx, nil) | ||
| require.Equal(t, txs[3], iter.Tx()) | ||
| require.Equal(t, txs[5], iter.Tx()) |
Contributor
Author
There was a problem hiding this comment.
If we don’t properly clear the sender index, tx[4] wil be returned here even though it should have been replaced and removed
tx[5] should be returned in any cases because it has the higher priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
If a transaction is replaced in the priority nonce mempool, we must also remove the sender’s indices associated with the old transaction. The missing cleanup step leads to significant bugs during priority nonce mempool testing.