Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 18, 2025

βœ… Checklist

  • πŸ§ͺ The component is unit tested
  • πŸ§ͺ The component includes E2E tests
  • πŸ—‘οΈ Old Cypress tests exclusive to the component are removed
  • πŸ“– The component is documented in storybook with an .mdx file
  • β™Ώ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • πŸ“¦ The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • πŸ¦₯ Slotted Content, public methods and properties are documented
  • πŸ”„ The component outputs the same Angular output as before with Stencil
  • 🏷️ The component declares the component type in the HTMLElementTagNameMap

https://coveord.atlassian.net/browse/KIT-4876

Copilot AI and others added 2 commits December 18, 2025 17:48
Copilot AI changed the title [WIP] Migrate atomic-insight-refine-toggle to Lit feat(atomic): migrate atomic-insight-refine-toggle to Lit Dec 18, 2025
Copilot AI requested a review from alexprudhomme December 18, 2025 17:58
@alexprudhomme alexprudhomme changed the title feat(atomic): migrate atomic-insight-refine-toggle to Lit chore(atomic): migrate atomic-insight-refine-toggle to Lit Dec 19, 2025
@alexprudhomme alexprudhomme marked this pull request as ready for review December 30, 2025 13:45
@alexprudhomme alexprudhomme requested review from a team as code owners December 30, 2025 13:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the atomic-insight-refine-toggle component from Stencil (.tsx) to Lit (.ts), aligning with the new Atomic component architecture. The component displays a button that opens a modal containing facets and sort components, and automatically creates an atomic-insight-refine-modal when added to the interface.

Key Changes:

  • Complete rewrite using Lit framework with decorators (@customElement, @bindings, @withTailwindStyles)
  • Simplified implementation by leveraging shared utilities (renderRefineToggleButton, refineToggleGuard)
  • Added comprehensive unit tests following Vitest conventions
  • Added Playwright E2E tests and proper Storybook documentation
  • Removed legacy Stencil-specific code and Cypress tests

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
atomic-insight-refine-toggle.ts New Lit component implementation with proper decorators and lifecycle methods
atomic-insight-refine-toggle.spec.ts Comprehensive unit tests covering controller initialization, rendering states, and user interactions
e2e/atomic-insight-refine-toggle.e2e.ts Playwright E2E tests for button visibility and accessibility
e2e/page-object.ts Page object pattern for E2E test abstraction
e2e/fixture.ts Test fixture setup for Playwright tests
atomic-insight-refine-toggle.new.stories.tsx Storybook story with proper configuration and facet integration
atomic-insight-refine-toggle.mdx Complete documentation explaining usage and facet management
search-status-controller.ts New test utility for mocking SearchStatus controller
index.ts, lazy-index.ts Component exports added for proper module exposure
custom-element-tags.ts Component tag registered for internal tracking
components.d.ts Stencil type definitions removed (replaced by Lit's global interface)
insight-panel.cypress.ts Legacy Cypress test removed as component now has Playwright tests

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants