-
Notifications
You must be signed in to change notification settings - Fork 39
chore(atomic): migrate atomic-insight-refine-toggle to Lit #6839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: alexprudhomme <[email protected]>
β¦ stories, e2e, and documentation Co-authored-by: alexprudhomme <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the atomic-insight-refine-toggle component from Stencil (.tsx) to Lit (.ts), aligning with the new Atomic component architecture. The component displays a button that opens a modal containing facets and sort components, and automatically creates an atomic-insight-refine-modal when added to the interface.
Key Changes:
- Complete rewrite using Lit framework with decorators (
@customElement,@bindings,@withTailwindStyles) - Simplified implementation by leveraging shared utilities (
renderRefineToggleButton,refineToggleGuard) - Added comprehensive unit tests following Vitest conventions
- Added Playwright E2E tests and proper Storybook documentation
- Removed legacy Stencil-specific code and Cypress tests
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
atomic-insight-refine-toggle.ts |
New Lit component implementation with proper decorators and lifecycle methods |
atomic-insight-refine-toggle.spec.ts |
Comprehensive unit tests covering controller initialization, rendering states, and user interactions |
e2e/atomic-insight-refine-toggle.e2e.ts |
Playwright E2E tests for button visibility and accessibility |
e2e/page-object.ts |
Page object pattern for E2E test abstraction |
e2e/fixture.ts |
Test fixture setup for Playwright tests |
atomic-insight-refine-toggle.new.stories.tsx |
Storybook story with proper configuration and facet integration |
atomic-insight-refine-toggle.mdx |
Complete documentation explaining usage and facet management |
search-status-controller.ts |
New test utility for mocking SearchStatus controller |
index.ts, lazy-index.ts |
Component exports added for proper module exposure |
custom-element-tags.ts |
Component tag registered for internal tracking |
components.d.ts |
Stencil type definitions removed (replaced by Lit's global interface) |
insight-panel.cypress.ts |
Legacy Cypress test removed as component now has Playwright tests |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
β Checklist
.mdxfileindex.tsandlazy-index.tsfiles.https://coveord.atlassian.net/browse/KIT-4876