-
Notifications
You must be signed in to change notification settings - Fork 154
feat : Add ZeroBuyAmount error handling in CalculateQuoteError #3975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@cowprotocol/frontend does it require any support from your side before merging this PR? |
|
just want to share here that Once this PR is merged, I’ll open a follow-up PR on the frontend to address this error and resolve the specific issue. btw already updated the code , just need to test it |
|
@dinesh11515 while we wait for the frontend team reply, could you make sure the checks are green? |
@jmg-duarte fixed lint issue, can we run checks again |
|
Hi! |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
m-sz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself is limited in scope and noncontroversial. If a need would arise to lift the restriction of zero buy amount it will be easy enough to revert also.
Description
added support to
ZeroBuyAmounterror in get order quotethere is
ZeroAmounterror in validation of quote during post order , but it's causing this issue in FE, to avoid this on first step, added this new Error.rarely we are seeing quotes with zero buy amount , here is the example quote i got this mrng