Skip to content

Conversation

@cuichen01
Copy link
Collaborator

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ckend/modules/observability/infra/rpc/auth/auth.go 0.00% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   69.48%   69.63%   +0.14%     
==========================================
  Files         616      616              
  Lines       58135    58142       +7     
==========================================
+ Hits        40397    40487      +90     
+ Misses      14775    14689      -86     
- Partials     2963     2966       +3     
Flag Coverage Δ
unittests 69.63% <81.81%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/infra/middleware/logs/logs.go 100.00% <100.00%> (+100.00%) ⬆️
...ckend/modules/observability/application/openapi.go 76.85% <100.00%> (+0.03%) ⬆️
...modules/observability/infra/workspace/workspace.go 100.00% <100.00%> (ø)
...ckend/modules/observability/infra/rpc/auth/auth.go 63.24% <0.00%> (+26.72%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c143927...5dbbd81. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

claim := o.auth.GetClaim(ctx)
for i := range spans {
workspaceID := o.workspace.GetIngestWorkSpaceID(ctx, []*span.InputSpan{spans[i]})
workspaceID := o.workspace.GetIngestWorkSpaceID(ctx, []*span.InputSpan{spans[i]}, claim)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WorkspaceProviderImpl本来就是内部实现的对吧,能不能在WorkspaceProviderImpl里面去调auth?这样就不用暴露到开源上了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants