-
Notifications
You must be signed in to change notification settings - Fork 720
[feat][backend] trace_log_optimize #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
(LogID: 20251225204131010091094197501FDE7) Co-Authored-By: Coda <[email protected]>
(LogID: 20251225204131010091094197501FDE7) Co-Authored-By: Coda <[email protected]>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 69.48% 69.63% +0.14%
==========================================
Files 616 616
Lines 58135 58142 +7
==========================================
+ Hits 40397 40487 +90
+ Misses 14775 14689 -86
- Partials 2963 2966 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| claim := o.auth.GetClaim(ctx) | ||
| for i := range spans { | ||
| workspaceID := o.workspace.GetIngestWorkSpaceID(ctx, []*span.InputSpan{spans[i]}) | ||
| workspaceID := o.workspace.GetIngestWorkSpaceID(ctx, []*span.InputSpan{spans[i]}, claim) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WorkspaceProviderImpl本来就是内部实现的对吧,能不能在WorkspaceProviderImpl里面去调auth?这样就不用暴露到开源上了
What type of PR is this?
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes