-
Notifications
You must be signed in to change notification settings - Fork 23
errors.Join drops operator hints from the gates that need them most #242
Copy link
Copy link
Open
Labels
area/applyIssues or PRs related to talm apply (preflight, COSI validation, ApplyConfiguration flow)Issues or PRs related to talm apply (preflight, COSI validation, ApplyConfiguration flow)area/commandsIssues or PRs related to pkg/commands (CLI subcommands, flag parsing, root detection)Issues or PRs related to pkg/commands (CLI subcommands, flag parsing, root detection)area/upgradeIssues or PRs related to talm upgrade flow (image extraction, post-upgrade verification)Issues or PRs related to talm upgrade flow (image extraction, post-upgrade verification)kind/bugCategorizes issue or PR as related to a bugCategorizes issue or PR as related to a bug
Description
Activity
Metadata
Metadata
Assignees
Labels
area/applyIssues or PRs related to talm apply (preflight, COSI validation, ApplyConfiguration flow)Issues or PRs related to talm apply (preflight, COSI validation, ApplyConfiguration flow)area/commandsIssues or PRs related to pkg/commands (CLI subcommands, flag parsing, root detection)Issues or PRs related to pkg/commands (CLI subcommands, flag parsing, root detection)area/upgradeIssues or PRs related to talm upgrade flow (image extraction, post-upgrade verification)Issues or PRs related to talm upgrade flow (image extraction, post-upgrade verification)kind/bugCategorizes issue or PR as related to a bugCategorizes issue or PR as related to a bug
errors.Joinin cockroachdb/errors does not carry the hints of the errors it joins, a single one included. Measured on the real path:main.gorenders operator guidance fromerrors.GetAllHints, so any hint attached below a join is dead. Two gates lose theirs.runPostUpgradeVersionVerifyInnerjoins errors carryingpostUpgradeVersionMismatchHint. That hint is the whole playbook for the A/B-rollback case: the two hypotheses, how to tell them apart,--post-upgrade-reconcile-window,--skip-post-upgrade-verify. None of it prints.runPostApplyGatesjoins errors fromverifyAppliedState, which areWithHint-bearing too.Both suites stay green because they assert the hint on the unjoined helper. The fix is one line per site:
errors.WithHint(joined, hint)after the join, with the assertion moved onto the joined error.