Add async_run and socket tests #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
please make the filenames for the tests the same as the header they test. e.g. corosio/socket.hpp and the test is in test/corosio/socket.cpp |
sgerbino
force-pushed
the
coroutine-socket-test
branch
2 times, most recently
from
b0fce8a to
cdf2219
Compare
Member
|
yeah lets merge this |
Contributor
Author
Based on your comment before, I think it makes more sense to separate |
sgerbino
force-pushed
the
coroutine-socket-test
branch
from
2dad5ea to
f0f0499
Compare
sgerbino
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.