Update project structure and dependencies #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friederbluemle
force-pushed
the
update-project
branch
4 times, most recently
from
2ac3ef4 to
7540b98
Compare
friederbluemle
force-pushed
the
update-project
branch
from
7540b98 to
0823948
Compare
- Gradle plugin 3.6.3 - Gradle Wrapper 5.6.4 - Update min and target sdk - Migrate to androidx
friederbluemle
force-pushed
the
update-project
branch
from
0823948 to
31cdcc0
Compare
|
can we merge this? |
Author
@animesh-sharama I wish we could, but I don't have write access to this repo. The last commit on master was created 3 years ago, so the repo looks pretty inactive to me. If you want a copy with all these updates, you can download it directly from my fork: https://github.com/friederbluemle/video-enabled-webview/archive/update-project.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a full project update and partial cleanup, making the project compatible with the latest version of Android Studio, and the latest build tools/dependencies.
It also enables a very basic GitHub Actions based CI (just running
./gradlew build).Example of a successful build: https://github.com/friederbluemle/video-enabled-webview/runs/524897949
Includes, supersedes, and closes #45
Once approved, please use a normal GitHub merge (i.e. NO rebase/squash merge) to integrate the commit(s) from the PR head branch. The changes are broken up into meaningful, atomic commits, and my branch should already be up-to-date with the latest base branch. If it isn't, or if you want me to change anything, please let me know, and I will update the branch as soon as possible. Thank you!