Skip to content

Add Test to show failing .join in populate #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrick-werner wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Test to show failing .join in populate #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1a72f1
Add test for FHIRPath join function in LibraryEngineTests
patrick-werner Nov 19, 2025
b6cbf94
Add test for FHIRPath join function in LibraryEngineTests
patrick-werner Nov 19, 2025
766982b
Merge branch 'master' into populate-with-join-expression-832
JPercival Nov 20, 2025
8f5c6ab
Merge branch 'master' into populate-with-join-expression-832
patrick-werner Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions cqf-fhir-cql/src/test/java/org/opencds/cqf/fhir/cql/LibraryEngineTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,4 +195,26 @@ void multipleExpressions() {
assertEquals(codeableConcept2, result3.get(0));
assertEquals(codeableConcept2.getCodingFirstRep().getDisplay(), ((StringType) result4.get(0)).getValue());
}

@Test
void fhirPathJoinFunction() {
// Test for .join() FHIRPath function which is used in SDC populate operations
// This test currently FAILS because join() is not supported in the CQL FHIRPath implementation
var patientId = "Patient/Patient1";
var patient = new Patient()
.addName(new HumanName().addGiven("Alice").addGiven("Marie").setFamily("Smith"))
.setId(patientId);

var params = parameters();
params.addParameter(part("%subject", patient));

// Test joining given names with a space separator
var expression = new CqfExpression(
"text/fhirpath",
"%subject.name.first().given.join(' ')",
null);

var result = libraryEngine.resolveExpression(patientId, expression, params, null, null, null, null);
assertEquals("Alice Marie", ((StringType) result.get(0)).getValue());
}
}
1 change: 1 addition & 0 deletions cqf-fhir-cr/src/main/java/org/opencds/cqf/fhir/cr/common/ExpressionProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import org.hl7.fhir.instance.model.api.IPrimitiveType;
import org.opencds.cqf.fhir.utility.Constants;
import org.opencds.cqf.fhir.utility.CqfExpression;
import org.opencds.cqf.fhir.utility.FhirPathCache;
import org.opencds.cqf.fhir.utility.adapter.IQuestionnaireItemComponentAdapter;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down