fixes threading issue with context loading#132
Merged
brynrhodes merged 1 commit intomasterfrom Apr 6, 2026
Merged
Conversation
|
Formatting check succeeded! |
Coverage Report
Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #132 +/- ##
============================================
- Coverage 75.25% 73.98% -1.28%
+ Complexity 365 355 -10
============================================
Files 44 44
Lines 1160 1153 -7
Branches 171 167 -4
============================================
- Hits 873 853 -20
- Misses 189 210 +21
+ Partials 98 90 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brynrhodes
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #130
When calling getContext, from the vscode extension, the LSP4J creates multiple threads that call
getContext(). If the resource isn't in the cache theIgContextgoes searching. This is a big issue with the hover provider, it can causes multiple threads to go out and search for the same files, when the cache is cold. IfIgContextcan't find the file locally, or in.fhir/packagesthen it attempts to download from thenpm registry. Once the cache is loaded, not an issue but when starting up it is a problem.