feat(#90): add getTotalCost() and getTagThrottledDuration() - #102
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90
What changed
NativeClient: added FFI declarations forfdb_transaction_get_total_cost,fdb_transaction_get_tag_throttled_durationandfdb_future_get_double.Future\FutureDoublefuture type (the throttled-duration future resolves to adoublein C).ReadTransaction::getTotalCost(): FutureInt64andReadTransaction::getTagThrottledDuration(): FutureDouble— inherited by bothTransactionandSnapshot.docs/transactions.mdupdated;CHANGELOG.mdentry added.Tests
tests/Unit/FutureDoubleTest.php(compiled C stub, same pattern asFutureBoolTest).tests/Integration/TransactionIntrospectionTest.php— cost grows with writes, 0.0 throttled duration on an unthrottled cluster, both accessible on snapshots. Verified against the local 5-node Docker cluster.composer lint(PHPCS + Rector dry-run + PHPStan L9) andcomposer testclean locally.